Commit 46a4cac7 authored by William Breathitt Gray's avatar William Breathitt Gray Committed by Jonathan Cameron

iio: addac: stx104: Use define rather than hardcoded limit for write val

The DAC register is 16 bits wide, so the value passed by write_raw()
should be checked against that limit. Rather than hardcoding the 16-bit
maximum value limit, use a define to improve readability and make the
intention of the code clearer. The explicit cast is also avoided by
instead explicitly checking for negative values.
Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarWilliam Breathitt Gray <william.gray@linaro.org>
Link: https://lore.kernel.org/r/4c9f4f1b4a270d133be70c82a091351b531b5e3e.1680790580.git.william.gray@linaro.orgSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 4f9b80ae
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/ioport.h> #include <linux/ioport.h>
#include <linux/isa.h> #include <linux/isa.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/limits.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/moduleparam.h> #include <linux/moduleparam.h>
#include <linux/mutex.h> #include <linux/mutex.h>
...@@ -181,8 +182,7 @@ static int stx104_write_raw(struct iio_dev *indio_dev, ...@@ -181,8 +182,7 @@ static int stx104_write_raw(struct iio_dev *indio_dev,
return 0; return 0;
case IIO_CHAN_INFO_RAW: case IIO_CHAN_INFO_RAW:
if (chan->output) { if (chan->output) {
/* DAC can only accept up to a 16-bit value */ if (val < 0 || val > U16_MAX)
if ((unsigned int)val > 65535)
return -EINVAL; return -EINVAL;
mutex_lock(&priv->lock); mutex_lock(&priv->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment