Commit 4b83b783 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Maxime Ripard

drm/imagination: move update_logtype() into ifdef section

This function is only used when debugfs is enabled, and otherwise
causes a build warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' defined but not used [-Werror=unused-function]

Move the #ifdef check to include this function as well.

Fixes: cb56cd61 ("drm/imagination: Add firmware trace to debugfs")
Acked-by: default avatarFrank Binns <frank.binns@imgtec.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20231204073231.1164163-1-arnd@kernel.orgSigned-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent e9d5ae8a
...@@ -121,6 +121,8 @@ void pvr_fw_trace_fini(struct pvr_device *pvr_dev) ...@@ -121,6 +121,8 @@ void pvr_fw_trace_fini(struct pvr_device *pvr_dev)
pvr_fw_object_unmap_and_destroy(fw_trace->tracebuf_ctrl_obj); pvr_fw_object_unmap_and_destroy(fw_trace->tracebuf_ctrl_obj);
} }
#if defined(CONFIG_DEBUG_FS)
/** /**
* update_logtype() - Send KCCB command to trigger FW to update logtype * update_logtype() - Send KCCB command to trigger FW to update logtype
* @pvr_dev: Target PowerVR device * @pvr_dev: Target PowerVR device
...@@ -165,8 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask) ...@@ -165,8 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask)
return err; return err;
} }
#if defined(CONFIG_DEBUG_FS)
struct pvr_fw_trace_seq_data { struct pvr_fw_trace_seq_data {
/** @buffer: Pointer to copy of trace data. */ /** @buffer: Pointer to copy of trace data. */
u32 *buffer; u32 *buffer;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment