Commit 4eba3fca authored by Lv Zheng's avatar Lv Zheng Committed by Ben Hutchings

ACPICA: Utilities: Cleanup to convert physical address printing formats.

commit cc2080b0 upstream.

ACPICA commit 7f06739db43a85083a70371c14141008f20b2198

For physical addresses, since the address may exceed 32-bit address range
after calculation, we should use %8.8X%8.8X (see ACPI_FORMAT_UINT64()) to
convert the %p formats.

This is a preparation to switch acpi_physical_address to 64-bit on 32-bit
kernel builds.

Link: https://github.com/acpica/acpica/commit/7f06739dSigned-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarDirk Behme <dirk.behme@gmail.com>
[gdavis: Move tbinstall.c changes to tbutils.c due to lack of commit
	 "42f47869 ACPICA: Split table print utilities to a new a
	 separate file" in linux-3.10.y]
Signed-off-by: default avatarGeorge G. Davis <george_davis@mentor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2:
 - Drop inapplicable changes to drivers/acpi/acpica/utaddress.c and
   acpi_tb_install_table()
 - Fix similar format issues in acpi_tb_add_table() and
   acpi_tb_install_table() that aren't present upstream]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 0e3c5ec2
...@@ -257,17 +257,15 @@ acpi_ex_access_region(union acpi_operand_object *obj_desc, ...@@ -257,17 +257,15 @@ acpi_ex_access_region(union acpi_operand_object *obj_desc,
} }
ACPI_DEBUG_PRINT_RAW((ACPI_DB_BFIELD, ACPI_DEBUG_PRINT_RAW((ACPI_DB_BFIELD,
" Region [%s:%X], Width %X, ByteBase %X, Offset %X at %p\n", " Region [%s:%X], Width %X, ByteBase %X, Offset %X at %8.8X%8.8X\n",
acpi_ut_get_region_name(rgn_desc->region. acpi_ut_get_region_name(rgn_desc->region.
space_id), space_id),
rgn_desc->region.space_id, rgn_desc->region.space_id,
obj_desc->common_field.access_byte_width, obj_desc->common_field.access_byte_width,
obj_desc->common_field.base_byte_offset, obj_desc->common_field.base_byte_offset,
field_datum_byte_offset, ACPI_CAST_PTR(void, field_datum_byte_offset,
(rgn_desc-> ACPI_FORMAT_UINT64(rgn_desc->region.address +
region. region_offset)));
address +
region_offset))));
/* Invoke the appropriate address_space/op_region handler */ /* Invoke the appropriate address_space/op_region handler */
......
...@@ -141,17 +141,17 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width) ...@@ -141,17 +141,17 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width)
byte_width = ACPI_DIV_8(bit_width); byte_width = ACPI_DIV_8(bit_width);
last_address = address + byte_width - 1; last_address = address + byte_width - 1;
ACPI_DEBUG_PRINT((ACPI_DB_IO, "Address %p LastAddress %p Length %X", ACPI_DEBUG_PRINT((ACPI_DB_IO,
ACPI_CAST_PTR(void, address), ACPI_CAST_PTR(void, "Address %8.8X%8.8X LastAddress %8.8X%8.8X Length %X",
last_address), ACPI_FORMAT_UINT64(address),
byte_width)); ACPI_FORMAT_UINT64(last_address), byte_width));
/* Maximum 16-bit address in I/O space */ /* Maximum 16-bit address in I/O space */
if (last_address > ACPI_UINT16_MAX) { if (last_address > ACPI_UINT16_MAX) {
ACPI_ERROR((AE_INFO, ACPI_ERROR((AE_INFO,
"Illegal I/O port address/length above 64K: %p/0x%X", "Illegal I/O port address/length above 64K: %8.8X%8.8X/0x%X",
ACPI_CAST_PTR(void, address), byte_width)); ACPI_FORMAT_UINT64(address), byte_width));
return_ACPI_STATUS(AE_LIMIT); return_ACPI_STATUS(AE_LIMIT);
} }
...@@ -180,8 +180,8 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width) ...@@ -180,8 +180,8 @@ acpi_hw_validate_io_request(acpi_io_address address, u32 bit_width)
if (acpi_gbl_osi_data >= port_info->osi_dependency) { if (acpi_gbl_osi_data >= port_info->osi_dependency) {
ACPI_DEBUG_PRINT((ACPI_DB_IO, ACPI_DEBUG_PRINT((ACPI_DB_IO,
"Denied AML access to port 0x%p/%X (%s 0x%.4X-0x%.4X)", "Denied AML access to port 0x%8.8X%8.8X/%X (%s 0x%.4X-0x%.4X)",
ACPI_CAST_PTR(void, address), ACPI_FORMAT_UINT64(address),
byte_width, port_info->name, byte_width, port_info->name,
port_info->start, port_info->start,
port_info->end)); port_info->end));
......
...@@ -251,12 +251,11 @@ acpi_ns_dump_one_object(acpi_handle obj_handle, ...@@ -251,12 +251,11 @@ acpi_ns_dump_one_object(acpi_handle obj_handle,
switch (type) { switch (type) {
case ACPI_TYPE_PROCESSOR: case ACPI_TYPE_PROCESSOR:
acpi_os_printf("ID %02X Len %02X Addr %p\n", acpi_os_printf("ID %02X Len %02X Addr %8.8X%8.8X\n",
obj_desc->processor.proc_id, obj_desc->processor.proc_id,
obj_desc->processor.length, obj_desc->processor.length,
ACPI_CAST_PTR(void, ACPI_FORMAT_UINT64(obj_desc->processor.
obj_desc->processor. address));
address));
break; break;
case ACPI_TYPE_DEVICE: case ACPI_TYPE_DEVICE:
......
...@@ -228,9 +228,9 @@ acpi_tb_add_table(struct acpi_table_desc *table_desc, u32 *table_index) ...@@ -228,9 +228,9 @@ acpi_tb_add_table(struct acpi_table_desc *table_desc, u32 *table_index)
status = acpi_os_table_override(table_desc->pointer, &override_table); status = acpi_os_table_override(table_desc->pointer, &override_table);
if (ACPI_SUCCESS(status) && override_table) { if (ACPI_SUCCESS(status) && override_table) {
ACPI_INFO((AE_INFO, ACPI_INFO((AE_INFO,
"%4.4s @ 0x%p Table override, replaced with:", "%4.4s @ 0x%8.8X%8.8X Table override, replaced with:",
table_desc->pointer->signature, table_desc->pointer->signature,
ACPI_CAST_PTR(void, table_desc->address))); ACPI_FORMAT_UINT64(table_desc->address)));
/* We can delete the table that was passed as a parameter */ /* We can delete the table that was passed as a parameter */
......
...@@ -488,9 +488,8 @@ acpi_tb_install_table(acpi_physical_address address, ...@@ -488,9 +488,8 @@ acpi_tb_install_table(acpi_physical_address address,
status = acpi_os_table_override(mapped_table, &override_table); status = acpi_os_table_override(mapped_table, &override_table);
if (ACPI_SUCCESS(status) && override_table) { if (ACPI_SUCCESS(status) && override_table) {
ACPI_INFO((AE_INFO, ACPI_INFO((AE_INFO,
"%4.4s @ 0x%p Table override, replaced with:", "%4.4s @ 0x%8.8X%8.8X Table override, replaced with:",
mapped_table->signature, ACPI_CAST_PTR(void, mapped_table->signature, ACPI_FORMAT_UINT64(address)));
address)));
acpi_gbl_root_table_list.tables[table_index].pointer = acpi_gbl_root_table_list.tables[table_index].pointer =
override_table; override_table;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment