Commit 4f74a3b3 authored by Andre Przywara's avatar Andre Przywara Committed by Linus Walleij

pinctrl: pinmux: Suppress error message for -EPROBE_DEFER

EPROBE_DEFER error returns are not really critical, since they cancel
the probe process, but the kernel will return later and retry.
However, depending on the probe order, this might issue quite some
verbatim and scary, though pointless messages:

[    2.388731] 300b000.pinctrl: pin-224 (5000000.serial) status -517
[    2.397321] 300b000.pinctrl: could not request pin 224 (PH0) from group PH0  on device 300b000.pinctrl

Replace dev_err() with dev_err_probe(), which not only drops the
priority of the message from error to debug, but also puts some text
into debugfs' devices_deferred file, for later reference.
Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
Link: https://lore.kernel.org/r/20240305143859.2449147-1-andre.przywara@arm.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 576623d7
...@@ -188,8 +188,8 @@ static int pin_request(struct pinctrl_dev *pctldev, ...@@ -188,8 +188,8 @@ static int pin_request(struct pinctrl_dev *pctldev,
} }
out: out:
if (status) if (status)
dev_err(pctldev->dev, "pin-%d (%s) status %d\n", dev_err_probe(pctldev->dev, status, "pin-%d (%s)\n",
pin, owner, status); pin, owner);
return status; return status;
} }
...@@ -441,7 +441,7 @@ int pinmux_enable_setting(const struct pinctrl_setting *setting) ...@@ -441,7 +441,7 @@ int pinmux_enable_setting(const struct pinctrl_setting *setting)
pname = desc ? desc->name : "non-existing"; pname = desc ? desc->name : "non-existing";
gname = pctlops->get_group_name(pctldev, gname = pctlops->get_group_name(pctldev,
setting->data.mux.group); setting->data.mux.group);
dev_err(pctldev->dev, dev_err_probe(pctldev->dev, ret,
"could not request pin %d (%s) from group %s " "could not request pin %d (%s) from group %s "
" on device %s\n", " on device %s\n",
pins[i], pname, gname, pins[i], pname, gname,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment