Commit 5097a69d authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Andrew Morton

extract and use FILE_LINE macro

Extract nifty FILE_LINE useful for printk style debugging:

	printk("%s\n", FILE_LINE);

It should not be used en mass probably because __FILE__ string literals
can be merged while FILE_LINE's won't. But for debugging it is what
the doctor ordered.

Don't add leading and trailing underscores, they're painful to type. 
Trust me, I've tried both versions.

Link: https://lkml.kernel.org/r/ebf12ac4-5a61-4b12-b8b0-1253eb371332@p183Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c37e56ca
...@@ -643,7 +643,7 @@ __FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size, ...@@ -643,7 +643,7 @@ __FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size,
__q_size_field, #op), \ __q_size_field, #op), \
#op ": detected field-spanning write (size %zu) of single %s (size %zu)\n", \ #op ": detected field-spanning write (size %zu) of single %s (size %zu)\n", \
__fortify_size, \ __fortify_size, \
"field \"" #p "\" at " __FILE__ ":" __stringify(__LINE__), \ "field \"" #p "\" at " FILE_LINE, \
__p_size_field); \ __p_size_field); \
__underlying_##op(p, q, __fortify_size); \ __underlying_##op(p, q, __fortify_size); \
}) })
......
...@@ -9,4 +9,6 @@ ...@@ -9,4 +9,6 @@
#define __stringify_1(x...) #x #define __stringify_1(x...) #x
#define __stringify(x...) __stringify_1(x) #define __stringify(x...) __stringify_1(x)
#define FILE_LINE __FILE__ ":" __stringify(__LINE__)
#endif /* !__LINUX_STRINGIFY_H */ #endif /* !__LINUX_STRINGIFY_H */
...@@ -77,8 +77,7 @@ struct timer_list { ...@@ -77,8 +77,7 @@ struct timer_list {
.entry = { .next = TIMER_ENTRY_STATIC }, \ .entry = { .next = TIMER_ENTRY_STATIC }, \
.function = (_function), \ .function = (_function), \
.flags = (_flags), \ .flags = (_flags), \
__TIMER_LOCKDEP_MAP_INITIALIZER( \ __TIMER_LOCKDEP_MAP_INITIALIZER(FILE_LINE) \
__FILE__ ":" __stringify(__LINE__)) \
} }
#define DEFINE_TIMER(_name, _function) \ #define DEFINE_TIMER(_name, _function) \
......
...@@ -29,16 +29,15 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0, /* always log errors */ ...@@ -29,16 +29,15 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0, /* always log errors */
the start of each message, eg see linux kernel hpios.h */ the start of each message, eg see linux kernel hpios.h */
#ifdef SOURCEFILE_NAME #ifdef SOURCEFILE_NAME
#undef FILE_LINE
#define FILE_LINE SOURCEFILE_NAME ":" __stringify(__LINE__) " " #define FILE_LINE SOURCEFILE_NAME ":" __stringify(__LINE__) " "
#else
#define FILE_LINE __FILE__ ":" __stringify(__LINE__) " "
#endif #endif
#define HPI_DEBUG_ASSERT(expression) \ #define HPI_DEBUG_ASSERT(expression) \
do { \ do { \
if (!(expression)) { \ if (!(expression)) { \
printk(KERN_ERR FILE_LINE \ printk(KERN_ERR FILE_LINE \
"ASSERT " __stringify(expression)); \ " ASSERT " __stringify(expression)); \
} \ } \
} while (0) } while (0)
...@@ -46,7 +45,7 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0, /* always log errors */ ...@@ -46,7 +45,7 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0, /* always log errors */
do { \ do { \
if (hpi_debug_level >= HPI_DEBUG_LEVEL_##level) { \ if (hpi_debug_level >= HPI_DEBUG_LEVEL_##level) { \
printk(HPI_DEBUG_FLAG_##level \ printk(HPI_DEBUG_FLAG_##level \
FILE_LINE __VA_ARGS__); \ FILE_LINE " " __VA_ARGS__); \
} \ } \
} while (0) } while (0)
...@@ -70,7 +69,7 @@ void hpi_debug_data(u16 *pdata, u32 len); ...@@ -70,7 +69,7 @@ void hpi_debug_data(u16 *pdata, u32 len);
do { \ do { \
if (hpi_debug_level >= HPI_DEBUG_LEVEL_##level) { \ if (hpi_debug_level >= HPI_DEBUG_LEVEL_##level) { \
hpi_debug_message(phm, HPI_DEBUG_FLAG_##level \ hpi_debug_message(phm, HPI_DEBUG_FLAG_##level \
FILE_LINE __stringify(level)); \ FILE_LINE " " __stringify(level)); \
} \ } \
} while (0) } while (0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment