Commit 51b98eff authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by Josef Bacik

btrfs: always choose work from prio_head first

In case we do not refill, we can overwrite cur pointer from prio_head
by one from not prioritized head, what looks as something that was
not intended.

This change make we always take works from prio_head first until it's
not empty.
Signed-off-by: default avatarStanislaw Gruszka <stf_xl@wp.pl>
Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
parent dcfd5ad2
...@@ -262,18 +262,19 @@ static struct btrfs_work *get_next_work(struct btrfs_worker_thread *worker, ...@@ -262,18 +262,19 @@ static struct btrfs_work *get_next_work(struct btrfs_worker_thread *worker,
struct btrfs_work *work = NULL; struct btrfs_work *work = NULL;
struct list_head *cur = NULL; struct list_head *cur = NULL;
if (!list_empty(prio_head)) if (!list_empty(prio_head)) {
cur = prio_head->next; cur = prio_head->next;
goto out;
}
smp_mb(); smp_mb();
if (!list_empty(&worker->prio_pending)) if (!list_empty(&worker->prio_pending))
goto refill; goto refill;
if (!list_empty(head)) if (!list_empty(head)) {
cur = head->next; cur = head->next;
if (cur)
goto out; goto out;
}
refill: refill:
spin_lock_irq(&worker->lock); spin_lock_irq(&worker->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment