Commit 55869f43 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab

media: dvb-frontends: drx39xyj: replace return with goto for proper unwind

In three places there was a return instead of a goto to the unwind
code.

This fixes three smatch warnings:

drxj.c:9542 ctrl_get_qam_sig_quality() warn: missing unwind goto?
drxj.c:10919 ctrl_set_standard() warn: missing unwind goto?
drxj.c:11466 drxj_open() warn: missing unwind goto?
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 5a1a39a8
...@@ -9539,7 +9539,8 @@ ctrl_get_qam_sig_quality(struct drx_demod_instance *demod) ...@@ -9539,7 +9539,8 @@ ctrl_get_qam_sig_quality(struct drx_demod_instance *demod)
qam_sl_sig_power = DRXJ_QAM_SL_SIG_POWER_QAM256 << 2; qam_sl_sig_power = DRXJ_QAM_SL_SIG_POWER_QAM256 << 2;
break; break;
default: default:
return -EIO; rc = -EIO;
goto rw_error;
} }
/* ------------------------------ */ /* ------------------------------ */
...@@ -10916,7 +10917,8 @@ ctrl_set_standard(struct drx_demod_instance *demod, enum drx_standard *standard) ...@@ -10916,7 +10917,8 @@ ctrl_set_standard(struct drx_demod_instance *demod, enum drx_standard *standard)
break; break;
case DRX_STANDARD_AUTO: case DRX_STANDARD_AUTO:
default: default:
return -EINVAL; rc = -EINVAL;
goto rw_error;
} }
/* /*
...@@ -11463,7 +11465,8 @@ static int drxj_open(struct drx_demod_instance *demod) ...@@ -11463,7 +11465,8 @@ static int drxj_open(struct drx_demod_instance *demod)
if (DRX_ISPOWERDOWNMODE(demod->my_common_attr->current_power_mode)) { if (DRX_ISPOWERDOWNMODE(demod->my_common_attr->current_power_mode)) {
pr_err("Should powerup before loading the firmware."); pr_err("Should powerup before loading the firmware.");
return -EINVAL; rc = -EINVAL;
goto rw_error;
} }
rc = drx_ctrl_u_code(demod, &ucode_info, UCODE_UPLOAD); rc = drx_ctrl_u_code(demod, &ucode_info, UCODE_UPLOAD);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment