Commit 59b304fd authored by Antoine Tenart's avatar Antoine Tenart Committed by Greg Kroah-Hartman

net: mvpp2: fix the mac address used when using PPv2.2


[ Upstream commit 4c228682 ]

The mac address is only retrieved from h/w when using PPv2.1. Otherwise
the variable holding it is still checked and used if it contains a valid
value. As the variable isn't initialized to an invalid mac address
value, we end up with random mac addresses which can be the same for all
the ports handled by this PPv2 driver.

Fixes this by initializing the h/w mac address variable to {0}, which is
an invalid mac address value. This way the random assignation fallback
is called and all ports end up with their own addresses.
Signed-off-by: default avatarAntoine Tenart <antoine.tenart@free-electrons.com>
Fixes: 26975821 ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 38ca2d39
...@@ -6465,7 +6465,7 @@ static int mvpp2_port_probe(struct platform_device *pdev, ...@@ -6465,7 +6465,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
struct resource *res; struct resource *res;
const char *dt_mac_addr; const char *dt_mac_addr;
const char *mac_from; const char *mac_from;
char hw_mac_addr[ETH_ALEN]; char hw_mac_addr[ETH_ALEN] = {0};
u32 id; u32 id;
int features; int features;
int phy_mode; int phy_mode;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment