Commit 5a7a88f1 authored by Ismail, Mustafa's avatar Ismail, Mustafa Committed by Doug Ledford

RDMA/uverbs: Fix the check for port number

The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.

Fixes: 5ecce4c9("Check port number supplied by user verbs cmds")
Cc: <stable@vger.kernel.org> # v2.6.14+
Reviewed-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarMustafa Ismail <mustafa.ismail@intel.com>
Tested-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 963916fd
...@@ -1933,7 +1933,8 @@ static int modify_qp(struct ib_uverbs_file *file, ...@@ -1933,7 +1933,8 @@ static int modify_qp(struct ib_uverbs_file *file,
goto out; goto out;
} }
if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) { if ((cmd->base.attr_mask & IB_QP_PORT) &&
!rdma_is_port_valid(qp->device, cmd->base.port_num)) {
ret = -EINVAL; ret = -EINVAL;
goto release_qp; goto release_qp;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment