Commit 5c6c313a authored by Marc Kleine-Budde's avatar Marc Kleine-Budde

can: gs_usb: gs_can_close(): don't complain about failed device reset during ndo_stop

When the USB device is unplugged, gs_can_close() (which implements the
struct net_device_ops::ndo_stop callback) is called. In this function
an attempt is made to shut down the USB device with a USB control
message. For disconnected devices this will fail and a warning message
is printed.

Silence the driver by removing the printout of the error message if
the reset command fails.

Link: https://lore.kernel.org/all/20230718-gs_usb-cleanups-v1-9-c3b9154ec605@pengutronix.deSigned-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 1494ffe4
...@@ -1029,9 +1029,7 @@ static int gs_can_close(struct net_device *netdev) ...@@ -1029,9 +1029,7 @@ static int gs_can_close(struct net_device *netdev)
dev->can.state = CAN_STATE_STOPPED; dev->can.state = CAN_STATE_STOPPED;
/* reset the device */ /* reset the device */
rc = gs_cmd_reset(dev); gs_cmd_reset(dev);
if (rc < 0)
netdev_warn(netdev, "Couldn't shutdown device (err=%d)", rc);
/* reset tx contexts */ /* reset tx contexts */
for (rc = 0; rc < GS_MAX_TX_URBS; rc++) { for (rc = 0; rc < GS_MAX_TX_URBS; rc++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment