Commit 5d9c7a1e authored by Lucy Mielke's avatar Lucy Mielke Committed by Tejun Heo

workqueue: fix -Wformat-truncation in create_worker

Compiling with W=1 emitted the following warning
(Compiler: gcc (x86-64, ver. 13.2.1, .config: result of make allyesconfig,
"Treat warnings as errors" turned off):

kernel/workqueue.c:2188:54: warning: ‘%d’ directive output may be
	truncated writing between 1 and 10 bytes into a region of size
	between 5 and 14 [-Wformat-truncation=]
kernel/workqueue.c:2188:50: note: directive argument in the range
	[0, 2147483647]
kernel/workqueue.c:2188:17: note: ‘snprintf’ output between 4 and 23 bytes
	into a destination of size 16

setting "id_buf" to size 23 will silence the warning, since GCC
determines snprintf's output to be max. 23 bytes in line 2188.

Please let me know if there are any mistakes in my patch!
Signed-off-by: default avatarLucy Mielke <lucymielke@icloud.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent ca10d851
...@@ -2166,7 +2166,7 @@ static struct worker *create_worker(struct worker_pool *pool) ...@@ -2166,7 +2166,7 @@ static struct worker *create_worker(struct worker_pool *pool)
{ {
struct worker *worker; struct worker *worker;
int id; int id;
char id_buf[16]; char id_buf[23];
/* ID is needed to determine kthread name */ /* ID is needed to determine kthread name */
id = ida_alloc(&pool->worker_ida, GFP_KERNEL); id = ida_alloc(&pool->worker_ida, GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment