Commit 5f034d34 authored by Amir Goldstein's avatar Amir Goldstein

ovl: propagate IOCB_APPEND flag on writes to realfile

If ovl file is opened O_APPEND, the underlying realfile is also
opened O_APPEND, so it makes sense to propagate the IOCB_APPEND flags
on sync writes to realfile, just as we do with aio writes.

Effectively, because sync ovl writes are protected by inode lock,
this change only makes a difference if the realfile is written to (size
extending writes) from underneath overlayfs.  The behavior in this case
is undefined, so it is ok if we change the behavior (to fail the ovl
IOCB_APPEND write).
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
parent db5b5e83
...@@ -264,7 +264,7 @@ static void ovl_file_accessed(struct file *file) ...@@ -264,7 +264,7 @@ static void ovl_file_accessed(struct file *file)
} }
#define OVL_IOCB_MASK \ #define OVL_IOCB_MASK \
(IOCB_NOWAIT | IOCB_HIPRI | IOCB_DSYNC | IOCB_SYNC) (IOCB_NOWAIT | IOCB_HIPRI | IOCB_DSYNC | IOCB_SYNC | IOCB_APPEND)
static rwf_t iocb_to_rw_flags(int flags) static rwf_t iocb_to_rw_flags(int flags)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment