Commit 63a15062 authored by Audra Mitchell's avatar Audra Mitchell Committed by Andrew Morton

tools/mm: filter out timestamps for correct collation

With the introduction of allocation timestamps being included in
page_owner output, each record becomes unique due to the timestamp
nanosecond granularity.  Remove the check in add_list that tries to
collate each record during processing as the memcmp() is just additional
overhead at this point.

Also keep the allocation timestamps, but allow collation to occur without
consideration of the allocation timestamp except in the case were
allocation timestamps are requested by the user (the -a option).

Link: https://lkml.kernel.org/r/20231013190350.579407-4-audra@redhat.comSigned-off-by: default avatarAudra Mitchell <audra@redhat.com>
Acked-by: default avatarRafael Aquini <aquini@redhat.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Georgi Djakov <djakov@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 0179c628
...@@ -203,6 +203,21 @@ static int compare_sort_condition(const void *p1, const void *p2) ...@@ -203,6 +203,21 @@ static int compare_sort_condition(const void *p1, const void *p2)
return cmp; return cmp;
} }
static int remove_pattern(regex_t *pattern, char *buf, int len)
{
regmatch_t pmatch[2];
int err;
err = regexec(pattern, buf, 2, pmatch, REG_NOTBOL);
if (err != 0 || pmatch[1].rm_so == -1)
return len;
memcpy(buf + pmatch[1].rm_so,
buf + pmatch[1].rm_eo, len - pmatch[1].rm_eo);
return len - (pmatch[1].rm_eo - pmatch[1].rm_so);
}
static int search_pattern(regex_t *pattern, char *pattern_str, char *buf) static int search_pattern(regex_t *pattern, char *pattern_str, char *buf)
{ {
int err, val_len; int err, val_len;
...@@ -443,13 +458,6 @@ static bool is_need(char *buf) ...@@ -443,13 +458,6 @@ static bool is_need(char *buf)
static bool add_list(char *buf, int len, char *ext_buf) static bool add_list(char *buf, int len, char *ext_buf)
{ {
if (list_size != 0 &&
len == list[list_size-1].len &&
memcmp(buf, list[list_size-1].txt, len) == 0) {
list[list_size-1].num++;
list[list_size-1].page_num += get_page_num(buf);
return true;
}
if (list_size == max_size) { if (list_size == max_size) {
fprintf(stderr, "max_size too small??\n"); fprintf(stderr, "max_size too small??\n");
return false; return false;
...@@ -465,6 +473,9 @@ static bool add_list(char *buf, int len, char *ext_buf) ...@@ -465,6 +473,9 @@ static bool add_list(char *buf, int len, char *ext_buf)
return false; return false;
} }
memcpy(list[list_size].txt, buf, len); memcpy(list[list_size].txt, buf, len);
if (sc.cmps[0] != compare_ts) {
len = remove_pattern(&ts_nsec_pattern, list[list_size].txt, len);
}
list[list_size].txt[len] = 0; list[list_size].txt[len] = 0;
list[list_size].len = len; list[list_size].len = len;
list[list_size].num = 1; list[list_size].num = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment