Commit 63eeafd4 authored by Xiaofei Tan's avatar Xiaofei Tan Committed by Greg Kroah-Hartman

tty: tty_jobctrl: Fix coding style issues of block comments

Fix coding style issues of block comments, reported by checkpatch.pl.
Besides, do some expression optimization for the sentenses.
Signed-off-by: default avatarXiaofei Tan <tanxiaofei@huawei.com>
Link: https://lore.kernel.org/r/1617779210-51576-5-git-send-email-tanxiaofei@huawei.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d4e1d903
...@@ -204,8 +204,10 @@ int tty_signal_session_leader(struct tty_struct *tty, int exit_session) ...@@ -204,8 +204,10 @@ int tty_signal_session_leader(struct tty_struct *tty, int exit_session)
spin_lock_irq(&p->sighand->siglock); spin_lock_irq(&p->sighand->siglock);
if (p->signal->tty == tty) { if (p->signal->tty == tty) {
p->signal->tty = NULL; p->signal->tty = NULL;
/* We defer the dereferences outside fo /*
the tasklist lock */ * We defer the dereferences outside of
* the tasklist lock.
*/
refs++; refs++;
} }
if (!p->signal->leader) { if (!p->signal->leader) {
...@@ -328,9 +330,11 @@ void disassociate_ctty(int on_exit) ...@@ -328,9 +330,11 @@ void disassociate_ctty(int on_exit)
*/ */
void no_tty(void) void no_tty(void)
{ {
/* FIXME: Review locking here. The tty_lock never covered any race /*
between a new association and proc_clear_tty but possible we need * FIXME: Review locking here. The tty_lock never covered any race
to protect against this anyway */ * between a new association and proc_clear_tty but possibly we need
* to protect against this anyway.
*/
struct task_struct *tsk = current; struct task_struct *tsk = current;
disassociate_ctty(0); disassociate_ctty(0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment