Commit 6dc3a12f authored by Lucas De Marchi's avatar Lucas De Marchi Committed by Rodrigo Vivi

drm/xe/guc: Normalize error messages with %#x

One of the messages was printed without 0x prefix, so it was not clear
if it was decimal or hex: make sure to add the prefix by using %#x.
While at it, normalize the other messages in the same function to follow
the same pattern.
Reviewed-by: default avatarGustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/20230611222447.2837573-3-lucas.demarchi@intel.comSigned-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 90738d86
...@@ -647,7 +647,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request, ...@@ -647,7 +647,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
GUC_HXG_MSG_0_ORIGIN, 50000, &reply, false); GUC_HXG_MSG_0_ORIGIN, 50000, &reply, false);
if (ret) { if (ret) {
timeout: timeout:
drm_err(&xe->drm, "mmio request 0x%08x: no reply 0x%08x\n", drm_err(&xe->drm, "mmio request %#x: no reply %#x\n",
request[0], reply); request[0], reply);
return ret; return ret;
} }
...@@ -673,7 +673,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request, ...@@ -673,7 +673,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
GUC_HXG_TYPE_NO_RESPONSE_RETRY) { GUC_HXG_TYPE_NO_RESPONSE_RETRY) {
u32 reason = FIELD_GET(GUC_HXG_RETRY_MSG_0_REASON, header); u32 reason = FIELD_GET(GUC_HXG_RETRY_MSG_0_REASON, header);
drm_dbg(&xe->drm, "mmio request %#x: retrying, reason %u\n", drm_dbg(&xe->drm, "mmio request %#x: retrying, reason %#x\n",
request[0], reason); request[0], reason);
goto retry; goto retry;
} }
...@@ -683,7 +683,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request, ...@@ -683,7 +683,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
u32 hint = FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, header); u32 hint = FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, header);
u32 error = FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, header); u32 error = FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, header);
drm_err(&xe->drm, "mmio request %#x: failure %x/%u\n", drm_err(&xe->drm, "mmio request %#x: failure %#x/%#x\n",
request[0], error, hint); request[0], error, hint);
return -ENXIO; return -ENXIO;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment