namei: simplify invalidation logics in lookup_dcache()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

namei: simplify invalidation logics in lookup_dcache()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
74ff0ffc · Al Viro · e9742b53 · 74ff0ffc
Commit 74ff0ffc authored Mar 05, 2016 by Al Viro
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 7 deletions

fs/namei.c fs/namei.c +3 -7

No files found.
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1458,14 +1458,10 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
 		if (dentry->d_flags & DCACHE_OP_REVALIDATE) {
 			error = d_revalidate(dentry, flags);
 			if (unlikely(error <= 0)) {
-				if (error < 0) {
+				if (!error)
-					dput(dentry);
-					return ERR_PTR(error);
-				} else {
 					d_invalidate(dentry);
-					dput(dentry);
+				dput(dentry);
-					dentry = NULL;
+				return ERR_PTR(error);
-				}
 			}
 		}
 	}