Commit 752b0694 authored by Salil Mehta's avatar Salil Mehta Committed by David S. Miller

net: hns3: Fixes the wrong IS_ERR check on the returned phydev value

This patch removes the wrong check being done for the phy device being
returned by the mdiobus_get_phy() function. This function never returns
the error pointers.

Fixes: 256727da ("net: hns3: Add MDIO support to HNS3 Ethernet
Driver for hip08 SoC")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dc8007e8
...@@ -150,7 +150,7 @@ int hclge_mac_mdio_config(struct hclge_dev *hdev) ...@@ -150,7 +150,7 @@ int hclge_mac_mdio_config(struct hclge_dev *hdev)
} }
phydev = mdiobus_get_phy(mdio_bus, mac->phy_addr); phydev = mdiobus_get_phy(mdio_bus, mac->phy_addr);
if (!phydev || IS_ERR(phydev)) { if (!phydev) {
dev_err(mdio_bus->parent, "Failed to get phy device\n"); dev_err(mdio_bus->parent, "Failed to get phy device\n");
mdiobus_unregister(mdio_bus); mdiobus_unregister(mdio_bus);
return -EIO; return -EIO;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment