Commit 7e46aa5c authored by Al Viro's avatar Al Viro Committed by Linus Torvalds

regression: bfs endianness bug

BFS_FILEBLOCKS() expects struct bfs_inode * (on-disk data, with little-
endian fields), not struct bfs_inode_info * (in-core stuff, with host-
endian ones).

It's a macro and fields with the right names are present in
bfs_inode_info, so it compiles, but on big-endian host it gives bogus
results.

Introduced in commit f433dc56 ("Fixes to
the BFS filesystem driver").
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3c50b368
...@@ -178,7 +178,8 @@ static void bfs_delete_inode(struct inode *inode) ...@@ -178,7 +178,8 @@ static void bfs_delete_inode(struct inode *inode)
brelse(bh); brelse(bh);
if (bi->i_dsk_ino) { if (bi->i_dsk_ino) {
info->si_freeb += BFS_FILEBLOCKS(bi); if (bi->i_sblock)
info->si_freeb += bi->i_eblock + 1 - bi->i_sblock;
info->si_freei++; info->si_freei++;
clear_bit(ino, info->si_imap); clear_bit(ino, info->si_imap);
dump_imap("delete_inode", s); dump_imap("delete_inode", s);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment