Commit 8e4c309f authored by Sascha Hauer's avatar Sascha Hauer Committed by Jens Axboe

ata: sata_nv: Fix retrieving of active qcs

ata_qc_complete_multiple() has to be called with the tags physically
active, that is the hw tag is at bit 0. ap->qc_active has the same tag
at bit ATA_TAG_INTERNAL instead, so call ata_qc_get_active() to fix that
up. This is done in the vein of 8385d756 ("libata: Fix retrieving of
active qcs").

Fixes: 28361c40 ("libata: add extra internal command")
Tested-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 94bd5719
...@@ -2100,7 +2100,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap) ...@@ -2100,7 +2100,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
pp->dhfis_bits &= ~done_mask; pp->dhfis_bits &= ~done_mask;
pp->dmafis_bits &= ~done_mask; pp->dmafis_bits &= ~done_mask;
pp->sdbfis_bits |= done_mask; pp->sdbfis_bits |= done_mask;
ata_qc_complete_multiple(ap, ap->qc_active ^ done_mask); ata_qc_complete_multiple(ap, ata_qc_get_active(ap) ^ done_mask);
if (!ap->qc_active) { if (!ap->qc_active) {
DPRINTK("over\n"); DPRINTK("over\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment