Commit 8ea8613a authored by Jiajian Ye's avatar Jiajian Ye Committed by Linus Torvalds

tools/vm/page_owner_sort.c: support for selecting by PID, TGID or task command name

When viewing page owner information, we may also need to select the blocks
by PID, TGID or task command name, which helps to get more accurate page
allocation information as needed.

Therefore, following adjustments are made:

1. Add three new options, including --pid, --tgid and --name, to support
   the selection of information blocks by a specific pid, tgid and task
   command name. In addtion, multiple options are allowed to be used at
   the same time.

	./page_owner_sort [input] [output] --pid <PID>
	./page_owner_sort [input] [output] --tgid <TGID>
	./page_owner_sort [input] [output] --name <TASK_COMMAND_NAME>

   Assuming a scenario when a multi-threaded program, ./demo (PID =
   5280), is running, and ./demo creates a child process (PID = 5281).

	$ps
	PID   TTY        TIME   CMD
	5215  pts/0    00:00:00  bash
	5280  pts/0    00:00:00  ./demo
	5281  pts/0    00:00:00  ./demo
	5282  pts/0    00:00:00  ps

   It would be better to filter out the records with tgid=5280 and the
   task name "demo" when debugging the parent process, and the specific
   usage is

	./page_owner_sort [input] [output] --tgid 5280 --name demo

2. Add explanations of three new options, including --pid, --tgid and
   --name, to the document.

This work is coauthored by
	Shenghong Han <hanshenghong2019@email.szu.edu.cn>,
	Yixuan Cao <caoyixuan2019@email.szu.edu.cn>,
	Yinan Zhang <zhangyinan2019@email.szu.edu.cn>,
	Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>,
	Yuhong Feng <yuhongf@szu.edu.cn>.

Link: https://lkml.kernel.org/r/1646835223-7584-1-git-send-email-yejiajian2018@email.szu.edu.cnSigned-off-by: default avatarJiajian Ye <yejiajian2018@email.szu.edu.cn>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Zhenliang Wei <weizhenliang@huawei.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 194d52d7
...@@ -129,3 +129,8 @@ Usage ...@@ -129,3 +129,8 @@ Usage
Filter: Filter:
-f Filter out the information of blocks whose memory has been released. -f Filter out the information of blocks whose memory has been released.
Select:
--pid <PID> Select by pid.
--tgid <TGID> Select by tgid.
--name <command> Select by task command name.
...@@ -21,6 +21,12 @@ ...@@ -21,6 +21,12 @@
#include <regex.h> #include <regex.h>
#include <errno.h> #include <errno.h>
#include <linux/types.h> #include <linux/types.h>
#include <getopt.h>
#define bool int
#define true 1
#define false 0
#define TASK_COMM_LEN 16
struct block_list { struct block_list {
char *txt; char *txt;
...@@ -34,7 +40,18 @@ struct block_list { ...@@ -34,7 +40,18 @@ struct block_list {
pid_t pid; pid_t pid;
pid_t tgid; pid_t tgid;
}; };
enum FILTER_BIT {
FILTER_UNRELEASE = 1<<1,
FILTER_PID = 1<<2,
FILTER_TGID = 1<<3,
FILTER_TASK_COMM_NAME = 1<<4
};
struct filter_condition {
pid_t tgid;
pid_t pid;
char comm[TASK_COMM_LEN];
};
static struct filter_condition fc;
static regex_t order_pattern; static regex_t order_pattern;
static regex_t pid_pattern; static regex_t pid_pattern;
static regex_t tgid_pattern; static regex_t tgid_pattern;
...@@ -154,7 +171,6 @@ static void check_regcomp(regex_t *pattern, const char *regex) ...@@ -154,7 +171,6 @@ static void check_regcomp(regex_t *pattern, const char *regex)
} }
# define FIELD_BUFF 25 # define FIELD_BUFF 25
# define TASK_COMM_LEN 16
static int get_page_num(char *buf) static int get_page_num(char *buf)
{ {
...@@ -259,11 +275,30 @@ static char *get_comm(char *buf) ...@@ -259,11 +275,30 @@ static char *get_comm(char *buf)
return comm_str; return comm_str;
} }
static bool is_need(char *buf)
{
if ((filter & FILTER_UNRELEASE) != 0 && get_free_ts_nsec(buf) != 0)
return false;
if ((filter & FILTER_PID) != 0 && get_pid(buf) != fc.pid)
return false;
if ((filter & FILTER_TGID) != 0 && get_tgid(buf) != fc.tgid)
return false;
char *comm = get_comm(buf);
if ((filter & FILTER_TASK_COMM_NAME) != 0 &&
strncmp(comm, fc.comm, TASK_COMM_LEN) != 0) {
free(comm);
return false;
}
return true;
}
static void add_list(char *buf, int len) static void add_list(char *buf, int len)
{ {
if (list_size != 0 && if (list_size != 0 &&
len == list[list_size-1].len && len == list[list_size-1].len &&
memcmp(buf, list[list_size-1].txt, len) == 0) { memcmp(buf, list[list_size-1].txt, len) == 0) {
list[list_size-1].num++; list[list_size-1].num++;
list[list_size-1].page_num += get_page_num(buf); list[list_size-1].page_num += get_page_num(buf);
return; return;
...@@ -272,28 +307,27 @@ static void add_list(char *buf, int len) ...@@ -272,28 +307,27 @@ static void add_list(char *buf, int len)
printf("max_size too small??\n"); printf("max_size too small??\n");
exit(1); exit(1);
} }
if (!is_need(buf))
list[list_size].free_ts_nsec = get_free_ts_nsec(buf);
if (filter == 1 && list[list_size].free_ts_nsec != 0)
return; return;
list[list_size].pid = get_pid(buf);
list[list_size].tgid = get_tgid(buf);
list[list_size].comm = get_comm(buf);
list[list_size].txt = malloc(len+1); list[list_size].txt = malloc(len+1);
if (!list[list_size].txt) { if (!list[list_size].txt) {
printf("Out of memory\n"); printf("Out of memory\n");
exit(1); exit(1);
} }
memcpy(list[list_size].txt, buf, len);
list[list_size].txt[len] = 0;
list[list_size].len = len; list[list_size].len = len;
list[list_size].num = 1; list[list_size].num = 1;
list[list_size].page_num = get_page_num(buf); list[list_size].page_num = get_page_num(buf);
memcpy(list[list_size].txt, buf, len);
list[list_size].txt[len] = 0;
list[list_size].stacktrace = strchr(list[list_size].txt, '\n') ?: ""; list[list_size].stacktrace = strchr(list[list_size].txt, '\n') ?: "";
if (*list[list_size].stacktrace == '\n') if (*list[list_size].stacktrace == '\n')
list[list_size].stacktrace++; list[list_size].stacktrace++;
list[list_size].pid = get_pid(buf);
list[list_size].tgid = get_tgid(buf);
list[list_size].comm = get_comm(buf);
list[list_size].ts_nsec = get_ts_nsec(buf); list[list_size].ts_nsec = get_ts_nsec(buf);
list[list_size].free_ts_nsec = get_free_ts_nsec(buf);
list_size++; list_size++;
if (list_size % 1000 == 0) { if (list_size % 1000 == 0) {
printf("loaded %d\r", list_size); printf("loaded %d\r", list_size);
...@@ -306,16 +340,19 @@ static void add_list(char *buf, int len) ...@@ -306,16 +340,19 @@ static void add_list(char *buf, int len)
static void usage(void) static void usage(void)
{ {
printf("Usage: ./page_owner_sort [OPTIONS] <input> <output>\n" printf("Usage: ./page_owner_sort [OPTIONS] <input> <output>\n"
"-m Sort by total memory.\n" "-m\t\tSort by total memory.\n"
"-s Sort by the stack trace.\n" "-s\t\tSort by the stack trace.\n"
"-t Sort by times (default).\n" "-t\t\tSort by times (default).\n"
"-p Sort by pid.\n" "-p\t\tSort by pid.\n"
"-P Sort by tgid.\n" "-P\t\tSort by tgid.\n"
"-n Sort by task command name.\n" "-n\t\tSort by task command name.\n"
"-a Sort by memory allocate time.\n" "-a\t\tSort by memory allocate time.\n"
"-r Sort by memory release time.\n" "-r\t\tSort by memory release time.\n"
"-c Cull by comparing stacktrace instead of total block.\n" "-c\t\tCull by comparing stacktrace instead of total block.\n"
"-f Filter out the information of blocks whose memory has been released.\n" "-f\t\tFilter out the information of blocks whose memory has been released.\n"
"--pid <PID>\tSelect by pid. This selects the information of blocks whose process ID number equals to <PID>.\n"
"--tgid <TGID>\tSelect by tgid. This selects the information of blocks whose Thread Group ID number equals to <TGID>.\n"
"--name <command>\n\t\tSelect by command name. This selects the information of blocks whose command name identical to <command>.\n"
); );
} }
...@@ -323,12 +360,18 @@ int main(int argc, char **argv) ...@@ -323,12 +360,18 @@ int main(int argc, char **argv)
{ {
int (*cmp)(const void *, const void *) = compare_num; int (*cmp)(const void *, const void *) = compare_num;
FILE *fin, *fout; FILE *fin, *fout;
char *buf; char *buf, *endptr;
int ret, i, count; int ret, i, count;
struct stat st; struct stat st;
int opt; int opt;
struct option longopts[] = {
while ((opt = getopt(argc, argv, "acfmnprstP")) != -1) { "pid", required_argument, NULL, 1 },
{ "tgid", required_argument, NULL, 2 },
{ "name", required_argument, NULL, 3 },
{ 0, 0, 0, 0},
};
while ((opt = getopt_long(argc, argv, "acfmnprstP", longopts, NULL)) != -1)
switch (opt) { switch (opt) {
case 'a': case 'a':
cmp = compare_ts; cmp = compare_ts;
...@@ -337,7 +380,7 @@ int main(int argc, char **argv) ...@@ -337,7 +380,7 @@ int main(int argc, char **argv)
cull_st = 1; cull_st = 1;
break; break;
case 'f': case 'f':
filter = 1; filter = filter | FILTER_UNRELEASE;
break; break;
case 'm': case 'm':
cmp = compare_page_num; cmp = compare_page_num;
...@@ -360,6 +403,29 @@ int main(int argc, char **argv) ...@@ -360,6 +403,29 @@ int main(int argc, char **argv)
case 'n': case 'n':
cmp = compare_comm; cmp = compare_comm;
break; break;
case 1:
filter = filter | FILTER_PID;
errno = 0;
fc.pid = strtol(optarg, &endptr, 10);
if (errno != 0 || endptr == optarg || *endptr != '\0') {
printf("wrong/invalid pid in from the command line:%s\n", optarg);
exit(1);
}
break;
case 2:
filter = filter | FILTER_TGID;
errno = 0;
fc.tgid = strtol(optarg, &endptr, 10);
if (errno != 0 || endptr == optarg || *endptr != '\0') {
printf("wrong/invalid tgid in from the command line:%s\n", optarg);
exit(1);
}
break;
case 3:
filter = filter | FILTER_TASK_COMM_NAME;
strncpy(fc.comm, optarg, TASK_COMM_LEN);
fc.comm[TASK_COMM_LEN-1] = '\0';
break;
default: default:
usage(); usage();
exit(1); exit(1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment