Commit 96d88f65 authored by Brian Foster's avatar Brian Foster Committed by Miklos Szeredi

virtiofs: include a newline in sysfs tag

The internal tag string doesn't contain a newline. Append one when
emitting the tag via sysfs.

[Stefan] Orthogonal to the newline issue, sysfs_emit(buf, "%s", fs->tag) is
needed to prevent format string injection.
Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
Fixes: a8f62f50 ("virtiofs: export filesystem tags through sysfs")
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent aef8acd7
...@@ -170,7 +170,7 @@ static ssize_t tag_show(struct kobject *kobj, ...@@ -170,7 +170,7 @@ static ssize_t tag_show(struct kobject *kobj,
{ {
struct virtio_fs *fs = container_of(kobj, struct virtio_fs, kobj); struct virtio_fs *fs = container_of(kobj, struct virtio_fs, kobj);
return sysfs_emit(buf, fs->tag); return sysfs_emit(buf, "%s\n", fs->tag);
} }
static struct kobj_attribute virtio_fs_tag_attr = __ATTR_RO(tag); static struct kobj_attribute virtio_fs_tag_attr = __ATTR_RO(tag);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment