Commit 9979c6e5 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Herbert Xu

crypto: cipher - On clone do crypto_mod_get()

The refcounter of underlying algorithm should be incremented, otherwise
it'll be destroyed with the cloned cipher, wrecking the original cipher.
Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent fa3b3565
...@@ -101,10 +101,15 @@ struct crypto_cipher *crypto_clone_cipher(struct crypto_cipher *cipher) ...@@ -101,10 +101,15 @@ struct crypto_cipher *crypto_clone_cipher(struct crypto_cipher *cipher)
if (alg->cra_init) if (alg->cra_init)
return ERR_PTR(-ENOSYS); return ERR_PTR(-ENOSYS);
if (unlikely(!crypto_mod_get(alg)))
return ERR_PTR(-ESTALE);
ntfm = __crypto_alloc_tfmgfp(alg, CRYPTO_ALG_TYPE_CIPHER, ntfm = __crypto_alloc_tfmgfp(alg, CRYPTO_ALG_TYPE_CIPHER,
CRYPTO_ALG_TYPE_MASK, GFP_ATOMIC); CRYPTO_ALG_TYPE_MASK, GFP_ATOMIC);
if (IS_ERR(ntfm)) if (IS_ERR(ntfm)) {
crypto_mod_put(alg);
return ERR_CAST(ntfm); return ERR_CAST(ntfm);
}
ntfm->crt_flags = tfm->crt_flags; ntfm->crt_flags = tfm->crt_flags;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment