Commit a301b2de authored by ye xingchen's avatar ye xingchen Committed by Jens Axboe

bcache: Convert to use sysfs_emit()/sysfs_emit_at() APIs

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: default avatarye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20230615121223.22502-2-colyli@suse.deSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent dd7de370
...@@ -1111,26 +1111,25 @@ SHOW(__bch_cache) ...@@ -1111,26 +1111,25 @@ SHOW(__bch_cache)
vfree(p); vfree(p);
ret = scnprintf(buf, PAGE_SIZE, ret = sysfs_emit(buf,
"Unused: %zu%%\n" "Unused: %zu%%\n"
"Clean: %zu%%\n" "Clean: %zu%%\n"
"Dirty: %zu%%\n" "Dirty: %zu%%\n"
"Metadata: %zu%%\n" "Metadata: %zu%%\n"
"Average: %llu\n" "Average: %llu\n"
"Sectors per Q: %zu\n" "Sectors per Q: %zu\n"
"Quantiles: [", "Quantiles: [",
unused * 100 / (size_t) ca->sb.nbuckets, unused * 100 / (size_t) ca->sb.nbuckets,
available * 100 / (size_t) ca->sb.nbuckets, available * 100 / (size_t) ca->sb.nbuckets,
dirty * 100 / (size_t) ca->sb.nbuckets, dirty * 100 / (size_t) ca->sb.nbuckets,
meta * 100 / (size_t) ca->sb.nbuckets, sum, meta * 100 / (size_t) ca->sb.nbuckets, sum,
n * ca->sb.bucket_size / (ARRAY_SIZE(q) + 1)); n * ca->sb.bucket_size / (ARRAY_SIZE(q) + 1));
for (i = 0; i < ARRAY_SIZE(q); i++) for (i = 0; i < ARRAY_SIZE(q); i++)
ret += scnprintf(buf + ret, PAGE_SIZE - ret, ret += sysfs_emit_at(buf, ret, "%u ", q[i]);
"%u ", q[i]);
ret--; ret--;
ret += scnprintf(buf + ret, PAGE_SIZE - ret, "]\n"); ret += sysfs_emit_at(buf, ret, "]\n");
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment