Commit a4014203 authored by Brian Norris's avatar Brian Norris Committed by Greg Kroah-Hartman

UBI: fix check for "too many bytes"

commit 299d0c5b upstream.

The comparison from the previous line seems to have been erroneously
(partially) copied-and-pasted onto the next. The second line should be
checking req.bytes, not req.lnum.

Coverity CID #139400
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
[rw: Fixed comparison]
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7e0a5b1f
...@@ -475,7 +475,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd, ...@@ -475,7 +475,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd,
/* Validate the request */ /* Validate the request */
err = -EINVAL; err = -EINVAL;
if (req.lnum < 0 || req.lnum >= vol->reserved_pebs || if (req.lnum < 0 || req.lnum >= vol->reserved_pebs ||
req.bytes < 0 || req.lnum >= vol->usable_leb_size) req.bytes < 0 || req.bytes > vol->usable_leb_size)
break; break;
err = get_exclusive(desc); err = get_exclusive(desc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment