Commit a64a8714 authored by David Herrmann's avatar David Herrmann Committed by Jiri Slaby

HID: hyperv: make sure input buffer is big enough

commit 3ccfd0a8 upstream.

We need at least HID_MAX_BUFFER_SIZE (4096) bytes as input buffer. HID
core depends on this as it requires every input report to be at least as
big as advertised.
Signed-off-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Cc: Oliver Neukum <ONeukum@suse.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 7d07816b
...@@ -157,6 +157,7 @@ struct mousevsc_dev { ...@@ -157,6 +157,7 @@ struct mousevsc_dev {
u32 report_desc_size; u32 report_desc_size;
struct hv_input_dev_info hid_dev_info; struct hv_input_dev_info hid_dev_info;
struct hid_device *hid_device; struct hid_device *hid_device;
u8 input_buf[HID_MAX_BUFFER_SIZE];
}; };
...@@ -256,6 +257,7 @@ static void mousevsc_on_receive(struct hv_device *device, ...@@ -256,6 +257,7 @@ static void mousevsc_on_receive(struct hv_device *device,
struct synthhid_msg *hid_msg; struct synthhid_msg *hid_msg;
struct mousevsc_dev *input_dev = hv_get_drvdata(device); struct mousevsc_dev *input_dev = hv_get_drvdata(device);
struct synthhid_input_report *input_report; struct synthhid_input_report *input_report;
size_t len;
pipe_msg = (struct pipe_prt_msg *)((unsigned long)packet + pipe_msg = (struct pipe_prt_msg *)((unsigned long)packet +
(packet->offset8 << 3)); (packet->offset8 << 3));
...@@ -300,9 +302,12 @@ static void mousevsc_on_receive(struct hv_device *device, ...@@ -300,9 +302,12 @@ static void mousevsc_on_receive(struct hv_device *device,
(struct synthhid_input_report *)pipe_msg->data; (struct synthhid_input_report *)pipe_msg->data;
if (!input_dev->init_complete) if (!input_dev->init_complete)
break; break;
hid_input_report(input_dev->hid_device,
HID_INPUT_REPORT, input_report->buffer, len = min(input_report->header.size,
input_report->header.size, 1); (u32)sizeof(input_dev->input_buf));
memcpy(input_dev->input_buf, input_report->buffer, len);
hid_input_report(input_dev->hid_device, HID_INPUT_REPORT,
input_dev->input_buf, len, 1);
break; break;
default: default:
pr_err("unsupported hid msg type - type %d len %d", pr_err("unsupported hid msg type - type %d len %d",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment