Commit a69c610e authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Alexandre Belloni

rtc: stm32: remove incorrect #ifdef check

After a previous commit changed the driver over to
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), the suspend/resume
functions must no longer be hidden behind an #ifdef:

In file included from include/linux/clk.h:13,
                 from drivers/rtc/rtc-stm32.c:8:
drivers/rtc/rtc-stm32.c:927:39: error: 'stm32_rtc_suspend' undeclared here (not in a function); did you mean 'stm32_rtc_probe'?
  927 |         SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume)
      |                                       ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:58:44: note: in definition of macro 'PTR_IF'
   58 | #define PTR_IF(cond, ptr)       ((cond) ? (ptr) : NULL)
      |                                            ^~~
include/linux/pm.h:329:26: note: in expansion of macro 'pm_sleep_ptr'
  329 |         .suspend_noirq = pm_sleep_ptr(suspend_fn), \
      |                          ^~~~~~~~~~~~

Fixes: fb9a7e53 ("rtc: stm32: change PM callbacks to "_noirq()"")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarValentin Caron <valentin.caron@foss.st.com>
Link: https://lore.kernel.org/r/20230801105932.3738430-1-arnd@kernel.orgSigned-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 58f3e832
...@@ -891,7 +891,6 @@ static void stm32_rtc_remove(struct platform_device *pdev) ...@@ -891,7 +891,6 @@ static void stm32_rtc_remove(struct platform_device *pdev)
device_init_wakeup(&pdev->dev, false); device_init_wakeup(&pdev->dev, false);
} }
#ifdef CONFIG_PM_SLEEP
static int stm32_rtc_suspend(struct device *dev) static int stm32_rtc_suspend(struct device *dev)
{ {
struct stm32_rtc *rtc = dev_get_drvdata(dev); struct stm32_rtc *rtc = dev_get_drvdata(dev);
...@@ -922,7 +921,6 @@ static int stm32_rtc_resume(struct device *dev) ...@@ -922,7 +921,6 @@ static int stm32_rtc_resume(struct device *dev)
return ret; return ret;
} }
#endif
static const struct dev_pm_ops stm32_rtc_pm_ops = { static const struct dev_pm_ops stm32_rtc_pm_ops = {
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment