Commit aaffa012 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab

media: rcar-vin: Fix a reference count leak.

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus call pm_runtime_put_noidle()
if pm_runtime_get_sync() fails.

Fixes: 90dedce9 ("media: rcar-vin: add function to manipulate Gen3 chsel value")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 98fae901
...@@ -1420,8 +1420,10 @@ int rvin_set_channel_routing(struct rvin_dev *vin, u8 chsel) ...@@ -1420,8 +1420,10 @@ int rvin_set_channel_routing(struct rvin_dev *vin, u8 chsel)
int ret; int ret;
ret = pm_runtime_get_sync(vin->dev); ret = pm_runtime_get_sync(vin->dev);
if (ret < 0) if (ret < 0) {
pm_runtime_put_noidle(vin->dev);
return ret; return ret;
}
/* Make register writes take effect immediately. */ /* Make register writes take effect immediately. */
vnmc = rvin_read(vin, VNMC_REG); vnmc = rvin_read(vin, VNMC_REG);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment