Commit ad8d68b2 authored by Eric Anholt's avatar Eric Anholt

drm/v3d: Add a note about OOM vs FLDONE, which may be racing on v3.3.

We deref v3d->bin_job in the work handler, but v3d->bin_job doesn't
actually hold a ref on the job.

v2: typo fix FRDONE -> FLDONE
Signed-off-by: default avatarEric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190313235211.28995-1-eric@anholt.netReviewed-by: default avatarDave Emett <david.emett@broadcom.com>
parent fc0c77fc
...@@ -87,7 +87,8 @@ v3d_irq(int irq, void *arg) ...@@ -87,7 +87,8 @@ v3d_irq(int irq, void *arg)
if (intsts & V3D_INT_OUTOMEM) { if (intsts & V3D_INT_OUTOMEM) {
/* Note that the OOM status is edge signaled, so the /* Note that the OOM status is edge signaled, so the
* interrupt won't happen again until the we actually * interrupt won't happen again until the we actually
* add more memory. * add more memory. Also, as of V3D 4.1, FLDONE won't
* be reported until any OOM state has been cleared.
*/ */
schedule_work(&v3d->overflow_mem_work); schedule_work(&v3d->overflow_mem_work);
status = IRQ_HANDLED; status = IRQ_HANDLED;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment