Commit ae02c7b7 authored by Lucas De Marchi's avatar Lucas De Marchi Committed by Rodrigo Vivi

drm/xe/rtp: Fix off-by-one when processing rules

Gustavo noticed an odd "+ 2" in rtp_mark_active() while processing
rtp rules and pointed that it should be "+ 1". In fact, while processing
entries without actions (OOB workarounds), if the WA is activated and
has OR rules, it will also inadvertently activate the very next
workaround.

Test in a LNL B0 platform by moving 18024947630 on top of 16020292621,
makes the latter become active:

	$ cat /sys/kernel/debug/dri/0/gt0/workarounds
	...
	OOB Workarounds
		18024947630
		16020292621
		14018094691
		16022287689
		13011645652
		22019338487_display

In future a kunit test will be added to cover the rtp checks for entries
without actions.

Fixes: fe19328b ("drm/xe/rtp: Add support for entries with no action")
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: default avatarGustavo Sousa <gustavo.sousa@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240726064337.797576-6-lucas.demarchi@intel.comSigned-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit fd6797ec)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent de9c2c66
...@@ -231,7 +231,7 @@ static void rtp_mark_active(struct xe_device *xe, ...@@ -231,7 +231,7 @@ static void rtp_mark_active(struct xe_device *xe,
if (first == last) if (first == last)
bitmap_set(ctx->active_entries, first, 1); bitmap_set(ctx->active_entries, first, 1);
else else
bitmap_set(ctx->active_entries, first, last - first + 2); bitmap_set(ctx->active_entries, first, last - first + 1);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment