Commit b56511c1 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Jason Gunthorpe

IB/mlx4: Avoid implicit enumerated type conversion

Clang warns when one enumerated type is implicitly converted to another.

drivers/infiniband/hw/mlx4/mad.c:1811:41: warning: implicit conversion
from enumeration type 'enum mlx4_ib_qp_flags' to different enumeration
type 'enum ib_qp_create_flags' [-Wenum-conversion]
                qp_init_attr.init_attr.create_flags = MLX4_IB_SRIOV_TUNNEL_QP;
                                                    ~ ^~~~~~~~~~~~~~~~~~~~~~~

drivers/infiniband/hw/mlx4/mad.c:1819:41: warning: implicit conversion
from enumeration type 'enum mlx4_ib_qp_flags' to different enumeration
type 'enum ib_qp_create_flags' [-Wenum-conversion]
                qp_init_attr.init_attr.create_flags = MLX4_IB_SRIOV_SQP;
                                                    ~ ^~~~~~~~~~~~~~~~~

The type mlx4_ib_qp_flags explicitly provides supplemental values to the
type ib_qp_create_flags. Make that clear to Clang by changing the
create_flags type to u32.
Reported-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent d9581bf3
...@@ -1151,7 +1151,7 @@ struct ib_qp_init_attr { ...@@ -1151,7 +1151,7 @@ struct ib_qp_init_attr {
struct ib_qp_cap cap; struct ib_qp_cap cap;
enum ib_sig_type sq_sig_type; enum ib_sig_type sq_sig_type;
enum ib_qp_type qp_type; enum ib_qp_type qp_type;
enum ib_qp_create_flags create_flags; u32 create_flags;
/* /*
* Only needed for special QP types, or when using the RW API. * Only needed for special QP types, or when using the RW API.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment