Commit b788dc51 authored by James Simmons's avatar James Simmons Committed by Greg Kroah-Hartman

staging: lustre: llite: drop acl from cache

Commit b8a7a3a6 change get_acl() for posix xattr to always cache
the ACL which increases the reference count. That reference count
can be reduced by have ll_get_acl() call forget_cached_acl() which
it wasn't. When an inode gets deleted by Lustre the POSIX ACL
reference count is tested to ensure its 1 and if not produces an error.
Since forget_cached_acl() was not called Lustre started to complain.
This patch changes ll_get_acl() to call forget_cached_acl().
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Reviewed-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c6c7a170
...@@ -3124,6 +3124,7 @@ struct posix_acl *ll_get_acl(struct inode *inode, int type) ...@@ -3124,6 +3124,7 @@ struct posix_acl *ll_get_acl(struct inode *inode, int type)
spin_lock(&lli->lli_lock); spin_lock(&lli->lli_lock);
/* VFS' acl_permission_check->check_acl will release the refcount */ /* VFS' acl_permission_check->check_acl will release the refcount */
acl = posix_acl_dup(lli->lli_posix_acl); acl = posix_acl_dup(lli->lli_posix_acl);
forget_cached_acl(inode, type);
spin_unlock(&lli->lli_lock); spin_unlock(&lli->lli_lock);
return acl; return acl;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment