Commit bab6ee73 authored by James Morse's avatar James Morse Committed by Borislav Petkov

x86/resctrl: Merge mon_capable and mon_enabled

mon_enabled and mon_capable are always set as a pair by
rdt_get_mon_l3_config().

There is no point having two values.

Merge them together.
Signed-off-by: default avatarJames Morse <james.morse@arm.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarJamie Iles <quic_jiles@quicinc.com>
Reviewed-by: default avatarShaopeng Tan <tan.shaopeng@fujitsu.com>
Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Tested-by: default avatarXin Hao <xhao@linux.alibaba.com>
Tested-by: default avatarShaopeng Tan <tan.shaopeng@fujitsu.com>
Tested-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20220902154829.30399-3-james.morse@arm.com
parent 4d269ed4
...@@ -459,10 +459,6 @@ int resctrl_arch_set_cdp_enabled(enum resctrl_res_level l, bool enable); ...@@ -459,10 +459,6 @@ int resctrl_arch_set_cdp_enabled(enum resctrl_res_level l, bool enable);
for_each_rdt_resource(r) \ for_each_rdt_resource(r) \
if (r->mon_capable) if (r->mon_capable)
#define for_each_mon_enabled_rdt_resource(r) \
for_each_rdt_resource(r) \
if (r->mon_enabled)
/* CPUID.(EAX=10H, ECX=ResID=1).EAX */ /* CPUID.(EAX=10H, ECX=ResID=1).EAX */
union cpuid_0x10_1_eax { union cpuid_0x10_1_eax {
struct { struct {
......
...@@ -717,7 +717,6 @@ int rdt_get_mon_l3_config(struct rdt_resource *r) ...@@ -717,7 +717,6 @@ int rdt_get_mon_l3_config(struct rdt_resource *r)
l3_mon_evt_init(r); l3_mon_evt_init(r);
r->mon_capable = true; r->mon_capable = true;
r->mon_enabled = true;
return 0; return 0;
} }
......
...@@ -1765,7 +1765,7 @@ static int rdtgroup_create_info_dir(struct kernfs_node *parent_kn) ...@@ -1765,7 +1765,7 @@ static int rdtgroup_create_info_dir(struct kernfs_node *parent_kn)
goto out_destroy; goto out_destroy;
} }
for_each_mon_enabled_rdt_resource(r) { for_each_mon_capable_rdt_resource(r) {
fflags = r->fflags | RF_MON_INFO; fflags = r->fflags | RF_MON_INFO;
sprintf(name, "%s_MON", r->name); sprintf(name, "%s_MON", r->name);
ret = rdtgroup_mkdir_info_resdir(r, name, fflags); ret = rdtgroup_mkdir_info_resdir(r, name, fflags);
...@@ -2504,7 +2504,7 @@ void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r, unsigned int dom_id) ...@@ -2504,7 +2504,7 @@ void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r, unsigned int dom_id)
struct rdtgroup *prgrp, *crgrp; struct rdtgroup *prgrp, *crgrp;
char name[32]; char name[32];
if (!r->mon_enabled) if (!r->mon_capable)
return; return;
list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) { list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) {
...@@ -2572,7 +2572,7 @@ void mkdir_mondata_subdir_allrdtgrp(struct rdt_resource *r, ...@@ -2572,7 +2572,7 @@ void mkdir_mondata_subdir_allrdtgrp(struct rdt_resource *r,
struct rdtgroup *prgrp, *crgrp; struct rdtgroup *prgrp, *crgrp;
struct list_head *head; struct list_head *head;
if (!r->mon_enabled) if (!r->mon_capable)
return; return;
list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) { list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) {
...@@ -2642,7 +2642,7 @@ static int mkdir_mondata_all(struct kernfs_node *parent_kn, ...@@ -2642,7 +2642,7 @@ static int mkdir_mondata_all(struct kernfs_node *parent_kn,
* Create the subdirectories for each domain. Note that all events * Create the subdirectories for each domain. Note that all events
* in a domain like L3 are grouped into a resource whose domain is L3 * in a domain like L3 are grouped into a resource whose domain is L3
*/ */
for_each_mon_enabled_rdt_resource(r) { for_each_mon_capable_rdt_resource(r) {
ret = mkdir_mondata_subdir_alldom(kn, r, prgrp); ret = mkdir_mondata_subdir_alldom(kn, r, prgrp);
if (ret) if (ret)
goto out_destroy; goto out_destroy;
......
...@@ -130,7 +130,6 @@ struct resctrl_schema; ...@@ -130,7 +130,6 @@ struct resctrl_schema;
/** /**
* struct rdt_resource - attributes of a resctrl resource * struct rdt_resource - attributes of a resctrl resource
* @rid: The index of the resource * @rid: The index of the resource
* @mon_enabled: Is monitoring enabled for this feature
* @alloc_capable: Is allocation available on this machine * @alloc_capable: Is allocation available on this machine
* @mon_capable: Is monitor feature available on this machine * @mon_capable: Is monitor feature available on this machine
* @num_rmid: Number of RMIDs available * @num_rmid: Number of RMIDs available
...@@ -149,7 +148,6 @@ struct resctrl_schema; ...@@ -149,7 +148,6 @@ struct resctrl_schema;
*/ */
struct rdt_resource { struct rdt_resource {
int rid; int rid;
bool mon_enabled;
bool alloc_capable; bool alloc_capable;
bool mon_capable; bool mon_capable;
int num_rmid; int num_rmid;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment