Commit c10bc561 authored by Niklas Cassel's avatar Niklas Cassel

ata,scsi: Remove wrappers ata_sas_tport_{add,delete}()

The ata_sas_tport_add() and ata_sas_tport_delete() wrappers only exist in
order to export the internal libata functions which they wrap.
Remove the wrappers and instead export the libata functions directly.
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240703184418.723066-12-cassel@kernel.orgSigned-off-by: default avatarNiklas Cassel <cassel@kernel.org>
parent 831d83a5
...@@ -1241,18 +1241,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host, ...@@ -1241,18 +1241,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host,
} }
EXPORT_SYMBOL_GPL(ata_sas_port_alloc); EXPORT_SYMBOL_GPL(ata_sas_port_alloc);
int ata_sas_tport_add(struct device *parent, struct ata_port *ap)
{
return ata_tport_add(parent, ap);
}
EXPORT_SYMBOL_GPL(ata_sas_tport_add);
void ata_sas_tport_delete(struct ata_port *ap)
{
ata_tport_delete(ap);
}
EXPORT_SYMBOL_GPL(ata_sas_tport_delete);
/** /**
* ata_sas_device_configure - Default device_configure routine for libata * ata_sas_device_configure - Default device_configure routine for libata
* devices * devices
......
...@@ -265,6 +265,7 @@ void ata_tport_delete(struct ata_port *ap) ...@@ -265,6 +265,7 @@ void ata_tport_delete(struct ata_port *ap)
transport_destroy_device(dev); transport_destroy_device(dev);
put_device(dev); put_device(dev);
} }
EXPORT_SYMBOL_GPL(ata_tport_delete);
static const struct device_type ata_port_sas_type = { static const struct device_type ata_port_sas_type = {
.name = ATA_PORT_TYPE_NAME, .name = ATA_PORT_TYPE_NAME,
...@@ -329,6 +330,7 @@ int ata_tport_add(struct device *parent, ...@@ -329,6 +330,7 @@ int ata_tport_add(struct device *parent,
put_device(dev); put_device(dev);
return error; return error;
} }
EXPORT_SYMBOL_GPL(ata_tport_add);
/** /**
* ata_port_classify - determine device type based on ATA-spec signature * ata_port_classify - determine device type based on ATA-spec signature
......
...@@ -8,9 +8,6 @@ extern struct scsi_transport_template *ata_scsi_transport_template; ...@@ -8,9 +8,6 @@ extern struct scsi_transport_template *ata_scsi_transport_template;
int ata_tlink_add(struct ata_link *link); int ata_tlink_add(struct ata_link *link);
void ata_tlink_delete(struct ata_link *link); void ata_tlink_delete(struct ata_link *link);
int ata_tport_add(struct device *parent, struct ata_port *ap);
void ata_tport_delete(struct ata_port *ap);
struct scsi_transport_template *ata_attach_transport(void); struct scsi_transport_template *ata_attach_transport(void);
void ata_release_transport(struct scsi_transport_template *t); void ata_release_transport(struct scsi_transport_template *t);
......
...@@ -608,7 +608,7 @@ int sas_ata_init(struct domain_device *found_dev) ...@@ -608,7 +608,7 @@ int sas_ata_init(struct domain_device *found_dev)
ap->cbl = ATA_CBL_SATA; ap->cbl = ATA_CBL_SATA;
ap->scsi_host = shost; ap->scsi_host = shost;
rc = ata_sas_tport_add(ata_host->dev, ap); rc = ata_tport_add(ata_host->dev, ap);
if (rc) if (rc)
goto free_port; goto free_port;
......
...@@ -300,7 +300,7 @@ void sas_free_device(struct kref *kref) ...@@ -300,7 +300,7 @@ void sas_free_device(struct kref *kref)
kfree(dev->ex_dev.ex_phy); kfree(dev->ex_dev.ex_phy);
if (dev_is_sata(dev) && dev->sata_dev.ap) { if (dev_is_sata(dev) && dev->sata_dev.ap) {
ata_sas_tport_delete(dev->sata_dev.ap); ata_tport_delete(dev->sata_dev.ap);
ata_port_free(dev->sata_dev.ap); ata_port_free(dev->sata_dev.ap);
ata_host_put(dev->sata_dev.ata_host); ata_host_put(dev->sata_dev.ata_host);
dev->sata_dev.ata_host = NULL; dev->sata_dev.ata_host = NULL;
......
...@@ -1250,8 +1250,8 @@ extern struct ata_port *ata_sas_port_alloc(struct ata_host *, ...@@ -1250,8 +1250,8 @@ extern struct ata_port *ata_sas_port_alloc(struct ata_host *,
struct ata_port_info *, struct Scsi_Host *); struct ata_port_info *, struct Scsi_Host *);
extern void ata_port_probe(struct ata_port *ap); extern void ata_port_probe(struct ata_port *ap);
extern void ata_port_free(struct ata_port *ap); extern void ata_port_free(struct ata_port *ap);
extern int ata_sas_tport_add(struct device *parent, struct ata_port *ap); extern int ata_tport_add(struct device *parent, struct ata_port *ap);
extern void ata_sas_tport_delete(struct ata_port *ap); extern void ata_tport_delete(struct ata_port *ap);
int ata_sas_device_configure(struct scsi_device *sdev, struct queue_limits *lim, int ata_sas_device_configure(struct scsi_device *sdev, struct queue_limits *lim,
struct ata_port *ap); struct ata_port *ap);
extern int ata_sas_queuecmd(struct scsi_cmnd *cmd, struct ata_port *ap); extern int ata_sas_queuecmd(struct scsi_cmnd *cmd, struct ata_port *ap);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment