Commit c2eecaa1 authored by Nick Richardson's avatar Nick Richardson Committed by David S. Miller

pktgen: Remove redundant clone_skb override

When the netif_receive xmit_mode is set, a line is supposed to set
clone_skb to a default 0 value. This line is made redundant due to a
preceding line that checks if clone_skb is more than zero and returns
-ENOTSUPP.

Overriding clone_skb to 0 does not make any difference to the behavior
because if it was positive we return error. So it can be either 0 or
negative, and in both cases the behavior is the same.

Remove redundant line that sets clone_skb to zero.
Signed-off-by: default avatarNick Richardson <richardsonnick@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 773bda96
...@@ -1190,11 +1190,6 @@ static ssize_t pktgen_if_write(struct file *file, ...@@ -1190,11 +1190,6 @@ static ssize_t pktgen_if_write(struct file *file,
* pktgen_xmit() is called * pktgen_xmit() is called
*/ */
pkt_dev->last_ok = 1; pkt_dev->last_ok = 1;
/* override clone_skb if user passed default value
* at module loading time
*/
pkt_dev->clone_skb = 0;
} else if (strcmp(f, "queue_xmit") == 0) { } else if (strcmp(f, "queue_xmit") == 0) {
pkt_dev->xmit_mode = M_QUEUE_XMIT; pkt_dev->xmit_mode = M_QUEUE_XMIT;
pkt_dev->last_ok = 1; pkt_dev->last_ok = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment