Commit c3dd7de2 authored by Benjamin Coddington's avatar Benjamin Coddington Committed by Trond Myklebust

NFS: Fix sysfs server name memory leak

Free the formatted server index string after it has been duplicated by
kobject_rename().

Fixes: 1c725118 ("NFS: add superblock sysfs entries")
Reported-by: default avatarAlexander Aring <aahringo@redhat.com>
Signed-off-by: default avatarBenjamin Coddington <bcodding@redhat.com>
Tested-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent be2fd156
......@@ -345,8 +345,10 @@ void nfs_sysfs_move_sb_to_server(struct nfs_server *server)
int ret = -ENOMEM;
s = kasprintf(GFP_KERNEL, "server-%d", server->s_sysfs_id);
if (s)
if (s) {
ret = kobject_rename(&server->kobj, s);
kfree(s);
}
if (ret < 0)
pr_warn("NFS: rename sysfs %s failed (%d)\n",
server->kobj.name, ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment