Commit c4e532f7 authored by Michael Strauss's avatar Michael Strauss Committed by Alex Deucher

drm/amd/display: Re-add aux intercept disable delay generically for 2+ LTTPRs

[WHY]
Issue not display generic, required for multiple 2+ LTTPR link configurations.

[HOW]
Revert monitor patch change and remove delay for single LTTPR case
Reviewed-by: default avatarGeorge Shen <george.shen@amd.com>
Acked-by: default avatarAlan Liu <haoping.liu@amd.com>
Signed-off-by: default avatarMichael Strauss <michael.strauss@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ac30aeae
...@@ -861,6 +861,7 @@ struct dc_debug_options { ...@@ -861,6 +861,7 @@ struct dc_debug_options {
bool psr_skip_crtc_disable; bool psr_skip_crtc_disable;
union dpia_debug_options dpia_debug; union dpia_debug_options dpia_debug;
bool disable_fixed_vs_aux_timeout_wa; bool disable_fixed_vs_aux_timeout_wa;
uint32_t fixed_vs_aux_delay_config_wa;
bool force_disable_subvp; bool force_disable_subvp;
bool force_subvp_mclk_switch; bool force_subvp_mclk_switch;
bool allow_sw_cursor_fallback; bool allow_sw_cursor_fallback;
......
...@@ -189,7 +189,6 @@ struct dc_panel_patch { ...@@ -189,7 +189,6 @@ struct dc_panel_patch {
unsigned int disable_fams; unsigned int disable_fams;
unsigned int skip_avmute; unsigned int skip_avmute;
unsigned int mst_start_top_delay; unsigned int mst_start_top_delay;
unsigned int delay_disable_aux_intercept_ms;
}; };
struct dc_edid_caps { struct dc_edid_caps {
......
...@@ -244,10 +244,6 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence_legacy( ...@@ -244,10 +244,6 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence_legacy(
uint8_t toggle_rate; uint8_t toggle_rate;
uint8_t rate; uint8_t rate;
if (link->local_sink)
pre_disable_intercept_delay_ms =
link->local_sink->edid_caps.panel_patch.delay_disable_aux_intercept_ms;
/* Only 8b/10b is supported */ /* Only 8b/10b is supported */
ASSERT(link_dp_get_encoding_format(&lt_settings->link_settings) == ASSERT(link_dp_get_encoding_format(&lt_settings->link_settings) ==
DP_8b_10b_ENCODING); DP_8b_10b_ENCODING);
...@@ -260,10 +256,13 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence_legacy( ...@@ -260,10 +256,13 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence_legacy(
if (offset != 0xFF) { if (offset != 0xFF) {
vendor_lttpr_write_address += vendor_lttpr_write_address +=
((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (offset - 1)); ((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (offset - 1));
if (offset == 2) {
pre_disable_intercept_delay_ms = link->dc->debug.fixed_vs_aux_delay_config_wa;
/* Certain display and cable configuration require extra delay */ /* Certain display and cable configuration require extra delay */
if (offset > 2) } else if (offset > 2) {
pre_disable_intercept_delay_ms = pre_disable_intercept_delay_ms * 2; pre_disable_intercept_delay_ms = link->dc->debug.fixed_vs_aux_delay_config_wa * 2;
}
} }
/* Vendor specific: Reset lane settings */ /* Vendor specific: Reset lane settings */
...@@ -596,9 +595,10 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence( ...@@ -596,9 +595,10 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence(
const uint8_t vendor_lttpr_write_data_adicora_eq1[4] = {0x1, 0x55, 0x63, 0x2E}; const uint8_t vendor_lttpr_write_data_adicora_eq1[4] = {0x1, 0x55, 0x63, 0x2E};
const uint8_t vendor_lttpr_write_data_adicora_eq2[4] = {0x1, 0x55, 0x63, 0x01}; const uint8_t vendor_lttpr_write_data_adicora_eq2[4] = {0x1, 0x55, 0x63, 0x01};
const uint8_t vendor_lttpr_write_data_adicora_eq3[4] = {0x1, 0x55, 0x63, 0x68}; const uint8_t vendor_lttpr_write_data_adicora_eq3[4] = {0x1, 0x55, 0x63, 0x68};
uint32_t pre_disable_intercept_delay_ms = 0;
uint8_t vendor_lttpr_write_data_vs[4] = {0x1, 0x51, 0x63, 0x0}; uint8_t vendor_lttpr_write_data_vs[4] = {0x1, 0x51, 0x63, 0x0};
uint8_t vendor_lttpr_write_data_pe[4] = {0x1, 0x52, 0x63, 0x0}; uint8_t vendor_lttpr_write_data_pe[4] = {0x1, 0x52, 0x63, 0x0};
uint32_t pre_disable_intercept_delay_ms = 0;
uint32_t vendor_lttpr_write_address = 0xF004F; uint32_t vendor_lttpr_write_address = 0xF004F;
enum link_training_result status = LINK_TRAINING_SUCCESS; enum link_training_result status = LINK_TRAINING_SUCCESS;
uint8_t lane = 0; uint8_t lane = 0;
...@@ -607,10 +607,6 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence( ...@@ -607,10 +607,6 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence(
uint8_t toggle_rate; uint8_t toggle_rate;
uint8_t rate; uint8_t rate;
if (link->local_sink)
pre_disable_intercept_delay_ms =
link->local_sink->edid_caps.panel_patch.delay_disable_aux_intercept_ms;
/* Only 8b/10b is supported */ /* Only 8b/10b is supported */
ASSERT(link_dp_get_encoding_format(&lt_settings->link_settings) == ASSERT(link_dp_get_encoding_format(&lt_settings->link_settings) ==
DP_8b_10b_ENCODING); DP_8b_10b_ENCODING);
...@@ -623,10 +619,13 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence( ...@@ -623,10 +619,13 @@ enum link_training_result dp_perform_fixed_vs_pe_training_sequence(
if (offset != 0xFF) { if (offset != 0xFF) {
vendor_lttpr_write_address += vendor_lttpr_write_address +=
((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (offset - 1)); ((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (offset - 1));
if (offset == 2) {
pre_disable_intercept_delay_ms = link->dc->debug.fixed_vs_aux_delay_config_wa;
/* Certain display and cable configuration require extra delay */ /* Certain display and cable configuration require extra delay */
if (offset > 2) } else if (offset > 2) {
pre_disable_intercept_delay_ms = pre_disable_intercept_delay_ms * 2; pre_disable_intercept_delay_ms = link->dc->debug.fixed_vs_aux_delay_config_wa * 2;
}
} }
/* Vendor specific: Reset lane settings */ /* Vendor specific: Reset lane settings */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment