Commit c6f78746 authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Mark Brown

spi: mediatek: Enable irq when pdata is ready

If the device does not come straight from reset, we might receive an IRQ
before we are ready to handle it.

Fixes:

[    0.832328] Unable to handle kernel read from unreadable memory at virtual address 0000000000000010
[    1.040343] Call trace:
[    1.040347]  mtk_spi_can_dma+0xc/0x40
...
[    1.262265]  start_kernel+0x338/0x42c
Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221128-spi-mt65xx-v1-0-509266830665@chromium.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 63d9a4d8
...@@ -1189,11 +1189,6 @@ static int mtk_spi_probe(struct platform_device *pdev) ...@@ -1189,11 +1189,6 @@ static int mtk_spi_probe(struct platform_device *pdev)
else else
dma_set_max_seg_size(dev, SZ_256K); dma_set_max_seg_size(dev, SZ_256K);
ret = devm_request_irq(dev, irq, mtk_spi_interrupt,
IRQF_TRIGGER_NONE, dev_name(dev), master);
if (ret)
return dev_err_probe(dev, ret, "failed to register irq\n");
mdata->parent_clk = devm_clk_get(dev, "parent-clk"); mdata->parent_clk = devm_clk_get(dev, "parent-clk");
if (IS_ERR(mdata->parent_clk)) if (IS_ERR(mdata->parent_clk))
return dev_err_probe(dev, PTR_ERR(mdata->parent_clk), return dev_err_probe(dev, PTR_ERR(mdata->parent_clk),
...@@ -1263,6 +1258,13 @@ static int mtk_spi_probe(struct platform_device *pdev) ...@@ -1263,6 +1258,13 @@ static int mtk_spi_probe(struct platform_device *pdev)
return dev_err_probe(dev, ret, "failed to register master\n"); return dev_err_probe(dev, ret, "failed to register master\n");
} }
ret = devm_request_irq(dev, irq, mtk_spi_interrupt,
IRQF_TRIGGER_NONE, dev_name(dev), master);
if (ret) {
pm_runtime_disable(dev);
return dev_err_probe(dev, ret, "failed to register irq\n");
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment