Commit c75a3772 authored by Nicholas Krause's avatar Nicholas Krause Committed by Linus Walleij

gpio: Fix error checking in the function device_pca957x_init

This fixes error checking in the function device_pca957x_init
to properly check and return error code values from the calls
to the function pca953x_write_regs if they fail as to properly
signal callers when a error occurs due a failure when writing
registers for this gpio based device.
Signed-off-by: default avatarNicholas Krause <xerofoify@gmail.com>
Reviewed-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 49a5bd88
...@@ -635,11 +635,15 @@ static int device_pca957x_init(struct pca953x_chip *chip, u32 invert) ...@@ -635,11 +635,15 @@ static int device_pca957x_init(struct pca953x_chip *chip, u32 invert)
memset(val, 0xFF, NBANK(chip)); memset(val, 0xFF, NBANK(chip));
else else
memset(val, 0, NBANK(chip)); memset(val, 0, NBANK(chip));
pca953x_write_regs(chip, PCA957X_INVRT, val); ret = pca953x_write_regs(chip, PCA957X_INVRT, val);
if (ret)
goto out;
/* To enable register 6, 7 to control pull up and pull down */ /* To enable register 6, 7 to control pull up and pull down */
memset(val, 0x02, NBANK(chip)); memset(val, 0x02, NBANK(chip));
pca953x_write_regs(chip, PCA957X_BKEN, val); ret = pca953x_write_regs(chip, PCA957X_BKEN, val);
if (ret)
goto out;
return 0; return 0;
out: out:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment