Commit cb3f35bb authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Christoph Hellwig

xfs: tiny cleanup for xfs_link

The source and target inodes are guaranteed to never be the same by the VFS,
so no need to check for that (and we would get into bad trouble later anyway
if that were the case).  Also clean up the error handling to use two gotos
instead of nested conditions.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarFelix Blyakher <felixb@sgi.com>
parent b93b6e43
...@@ -2004,8 +2004,10 @@ xfs_link( ...@@ -2004,8 +2004,10 @@ xfs_link(
/* Return through std_return after this point. */ /* Return through std_return after this point. */
error = XFS_QM_DQATTACH(mp, sip, 0); error = XFS_QM_DQATTACH(mp, sip, 0);
if (!error && sip != tdp) if (error)
error = XFS_QM_DQATTACH(mp, tdp, 0); goto std_return;
error = XFS_QM_DQATTACH(mp, tdp, 0);
if (error) if (error)
goto std_return; goto std_return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment