Commit cbfd7dab authored by Michael Ellerman's avatar Michael Ellerman Committed by Benjamin Herrenschmidt

selftests/powerpc: Don't ignore errors from sub Makefiles

Currently we ignore errors from our sub Makefiles. We inherited that
from the top-level selftests Makefile which aims to build and run as
many tests as possible and damn the torpedoes.

For the powerpc tests we'd instead like any errors to fail the build, so
we can automatically catch build failures.

We can achieve the best of both worlds by using -k, which tells make to
keep building when it hits an error, but still reports the error.
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 633440f1
...@@ -17,10 +17,10 @@ TARGETS = pmu copyloops mm tm ...@@ -17,10 +17,10 @@ TARGETS = pmu copyloops mm tm
endif endif
all: all: $(TARGETS)
@for TARGET in $(TARGETS); do \
$(MAKE) -C $$TARGET all; \ $(TARGETS):
done; $(MAKE) -k -C $@ all
run_tests: all run_tests: all
@for TARGET in $(TARGETS); do \ @for TARGET in $(TARGETS); do \
...@@ -36,4 +36,4 @@ clean: ...@@ -36,4 +36,4 @@ clean:
tags: tags:
find . -name '*.c' -o -name '*.h' | xargs ctags find . -name '*.c' -o -name '*.h' | xargs ctags
.PHONY: all run_tests clean tags .PHONY: all run_tests clean tags $(TARGETS)
...@@ -4,7 +4,9 @@ noarg: ...@@ -4,7 +4,9 @@ noarg:
PROGS := count_instructions PROGS := count_instructions
EXTRA_SOURCES := ../harness.c event.c EXTRA_SOURCES := ../harness.c event.c
all: $(PROGS) sub_all SUB_TARGETS = ebb
all: $(PROGS) $(SUB_TARGETS)
$(PROGS): $(EXTRA_SOURCES) $(PROGS): $(EXTRA_SOURCES)
...@@ -20,13 +22,8 @@ run_tests: all sub_run_tests ...@@ -20,13 +22,8 @@ run_tests: all sub_run_tests
clean: sub_clean clean: sub_clean
rm -f $(PROGS) loop.o rm -f $(PROGS) loop.o
$(SUB_TARGETS):
SUB_TARGETS = ebb $(MAKE) -k -C $@ all
sub_all:
@for TARGET in $(SUB_TARGETS); do \
$(MAKE) -C $$TARGET all; \
done;
sub_run_tests: all sub_run_tests: all
@for TARGET in $(SUB_TARGETS); do \ @for TARGET in $(SUB_TARGETS); do \
...@@ -38,4 +35,4 @@ sub_clean: ...@@ -38,4 +35,4 @@ sub_clean:
$(MAKE) -C $$TARGET clean; \ $(MAKE) -C $$TARGET clean; \
done; done;
.PHONY: all run_tests clean sub_all sub_run_tests sub_clean .PHONY: all run_tests clean sub_run_tests sub_clean $(SUB_TARGETS)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment