Commit cd0d465b authored by YueHaibing's avatar YueHaibing Committed by Jeff Kirsher

e100: Fix passing zero to 'PTR_ERR' warning in e100_load_ucode_wait

Fix a static code checker warning:
drivers/net/ethernet/intel/e100.c:1349
 e100_load_ucode_wait() warn: passing zero to 'PTR_ERR'
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent bad87ee8
...@@ -1345,8 +1345,8 @@ static inline int e100_load_ucode_wait(struct nic *nic) ...@@ -1345,8 +1345,8 @@ static inline int e100_load_ucode_wait(struct nic *nic)
fw = e100_request_firmware(nic); fw = e100_request_firmware(nic);
/* If it's NULL, then no ucode is required */ /* If it's NULL, then no ucode is required */
if (!fw || IS_ERR(fw)) if (IS_ERR_OR_NULL(fw))
return PTR_ERR(fw); return PTR_ERR_OR_ZERO(fw);
if ((err = e100_exec_cb(nic, (void *)fw, e100_setup_ucode))) if ((err = e100_exec_cb(nic, (void *)fw, e100_setup_ucode)))
netif_err(nic, probe, nic->netdev, netif_err(nic, probe, nic->netdev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment