Commit d1b622f6 authored by Fuqian Huang's avatar Fuqian Huang Committed by Vinod Koul

dmaengine: pl330: use the same attributes when freeing pl330->mcode_cpu

In function dmac_alloc_resources(), pl330->mcode_cpu is allocated using
dma_alloc_attrs() but freed with dma_free_coherent().
Use the correct dma_free_attrs() function to free pl330->mcode_cpu.
Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190726105947.25342-1-huangfq.daxian@gmail.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 057b05d5
...@@ -1922,9 +1922,10 @@ static int dmac_alloc_resources(struct pl330_dmac *pl330) ...@@ -1922,9 +1922,10 @@ static int dmac_alloc_resources(struct pl330_dmac *pl330)
if (ret) { if (ret) {
dev_err(pl330->ddma.dev, "%s:%d Can't to create channels for DMAC!\n", dev_err(pl330->ddma.dev, "%s:%d Can't to create channels for DMAC!\n",
__func__, __LINE__); __func__, __LINE__);
dma_free_coherent(pl330->ddma.dev, dma_free_attrs(pl330->ddma.dev,
chans * pl330->mcbufsz, chans * pl330->mcbufsz,
pl330->mcode_cpu, pl330->mcode_bus); pl330->mcode_cpu, pl330->mcode_bus,
DMA_ATTR_PRIVILEGED);
return ret; return ret;
} }
...@@ -2003,9 +2004,9 @@ static void pl330_del(struct pl330_dmac *pl330) ...@@ -2003,9 +2004,9 @@ static void pl330_del(struct pl330_dmac *pl330)
/* Free DMAC resources */ /* Free DMAC resources */
dmac_free_threads(pl330); dmac_free_threads(pl330);
dma_free_coherent(pl330->ddma.dev, dma_free_attrs(pl330->ddma.dev,
pl330->pcfg.num_chan * pl330->mcbufsz, pl330->mcode_cpu, pl330->pcfg.num_chan * pl330->mcbufsz, pl330->mcode_cpu,
pl330->mcode_bus); pl330->mcode_bus, DMA_ATTR_PRIVILEGED);
} }
/* forward declaration */ /* forward declaration */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment