Commit d2addf89 authored by Jocelyn Falempe's avatar Jocelyn Falempe

drm/mgag200: Warn once if trying to set start address on broken hardware.

Some MGA200 hardware is broken and can't use a start address > 0.

v2: Warn if startaddr is not 0, and hw doesn't support it.
  (instead of removing MGAG200_FLAG_HW_BUG_NO_STARTADD)
Signed-off-by: default avatarJocelyn Falempe <jfalempe@redhat.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220504134026.283417-4-jfalempe@redhat.com
parent c48a3630
...@@ -223,6 +223,9 @@ static void mgag200_set_startadd(struct mga_device *mdev, ...@@ -223,6 +223,9 @@ static void mgag200_set_startadd(struct mga_device *mdev,
startadd = offset / 8; startadd = offset / 8;
if (startadd > 0)
drm_WARN_ON_ONCE(dev, mdev->flags & MGAG200_FLAG_HW_BUG_NO_STARTADD);
/* /*
* Can't store addresses any higher than that, but we also * Can't store addresses any higher than that, but we also
* don't have more than 16 MiB of memory, so it should be fine. * don't have more than 16 MiB of memory, so it should be fine.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment