Commit d35df777 authored by Michael Walle's avatar Michael Walle Committed by Pratyush Yadav

mtd: spi-nor: winbond: fix w25q128 regression

Commit 83e824a4 ("mtd: spi-nor: Correct flags for Winbond w25q128")
removed the flags for non-SFDP devices. It was assumed that it wasn't in
use anymore. This wasn't true. Add the no_sfdp_flags as well as the size
again.

We add the additional flags for dual and quad read because they have
been reported to work properly by Hartmut using both older and newer
versions of this flash, the similar flashes with 64Mbit and 256Mbit
already have these flags and because it will (luckily) trigger our
legacy SFDP parsing, so newer versions with SFDP support will still get
the parameters from the SFDP tables.
Reported-by: default avatarHartmut Birr <e9hack@gmail.com>
Closes: https://lore.kernel.org/r/CALxbwRo_-9CaJmt7r7ELgu+vOcgk=xZcGHobnKf=oT2=u4d4aA@mail.gmail.com/
Fixes: 83e824a4 ("mtd: spi-nor: Correct flags for Winbond w25q128")
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMichael Walle <mwalle@kernel.org>
Acked-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Reviewed-by: default avatarEsben Haabendal <esben@geanix.com>
Reviewed-by: default avatarPratyush Yadav <pratyush@kernel.org>
Signed-off-by: default avatarPratyush Yadav <pratyush@kernel.org>
Link: https://lore.kernel.org/r/20240621120929.2670185-1-mwalle@kernel.org
parent e159079a
...@@ -105,7 +105,9 @@ static const struct flash_info winbond_nor_parts[] = { ...@@ -105,7 +105,9 @@ static const struct flash_info winbond_nor_parts[] = {
}, { }, {
.id = SNOR_ID(0xef, 0x40, 0x18), .id = SNOR_ID(0xef, 0x40, 0x18),
.name = "w25q128", .name = "w25q128",
.size = SZ_16M,
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
}, { }, {
.id = SNOR_ID(0xef, 0x40, 0x19), .id = SNOR_ID(0xef, 0x40, 0x19),
.name = "w25q256", .name = "w25q256",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment