Commit d6499f0b authored by Ruan Jinjie's avatar Ruan Jinjie Committed by David S. Miller

net: bgmac: Return PTR_ERR() for fixed_phy_register()

fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -ENODEV. The best practice is to return
these error codes with PTR_ERR().
Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b22eef68
...@@ -1450,7 +1450,7 @@ int bgmac_phy_connect_direct(struct bgmac *bgmac) ...@@ -1450,7 +1450,7 @@ int bgmac_phy_connect_direct(struct bgmac *bgmac)
phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
if (!phy_dev || IS_ERR(phy_dev)) { if (!phy_dev || IS_ERR(phy_dev)) {
dev_err(bgmac->dev, "Failed to register fixed PHY device\n"); dev_err(bgmac->dev, "Failed to register fixed PHY device\n");
return -ENODEV; return PTR_ERR(phy_dev);
} }
err = phy_connect_direct(bgmac->net_dev, phy_dev, bgmac_adjust_link, err = phy_connect_direct(bgmac->net_dev, phy_dev, bgmac_adjust_link,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment