Commit e14b77c3 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab

media: ov9640: Don't check for NULL on devm_gpiod_get return values

devm_gpiod_get never returns NULL; therefore it's not necessary to check
for that. PTR_ERR(NULL) also yields zero, which is confusing to smatch.
Reported-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 4ace2d28
...@@ -691,14 +691,14 @@ static int ov9640_probe(struct i2c_client *client, ...@@ -691,14 +691,14 @@ static int ov9640_probe(struct i2c_client *client,
priv->gpio_power = devm_gpiod_get(&client->dev, "Camera power", priv->gpio_power = devm_gpiod_get(&client->dev, "Camera power",
GPIOD_OUT_LOW); GPIOD_OUT_LOW);
if (IS_ERR_OR_NULL(priv->gpio_power)) { if (IS_ERR(priv->gpio_power)) {
ret = PTR_ERR(priv->gpio_power); ret = PTR_ERR(priv->gpio_power);
return ret; return ret;
} }
priv->gpio_reset = devm_gpiod_get(&client->dev, "Camera reset", priv->gpio_reset = devm_gpiod_get(&client->dev, "Camera reset",
GPIOD_OUT_HIGH); GPIOD_OUT_HIGH);
if (IS_ERR_OR_NULL(priv->gpio_reset)) { if (IS_ERR(priv->gpio_reset)) {
ret = PTR_ERR(priv->gpio_reset); ret = PTR_ERR(priv->gpio_reset);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment