Commit e1706f07 authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Alex Williamson

vfio/samples: Remove module get/put

The patch to move the get/put to core and the patch to convert the samples
to use vfio_device crossed in a way that this was missed. When both
patches are together the samples do not need their own get/put.

Fixes: 437e4136 ("vfio/mdpy: Convert to use vfio_register_group_dev()")
Fixes: 681c1615 ("vfio/mbochs: Convert to use vfio_register_group_dev()")
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarMax Gurtovoy <mgurtovoy@nvidia.com>
Link: https://lore.kernel.org/r/1-v4-9ea22c5e6afb+1adf-vfio_reflck_jgg@nvidia.comSigned-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 3fb1712d
...@@ -1274,9 +1274,6 @@ static long mbochs_ioctl(struct vfio_device *vdev, unsigned int cmd, ...@@ -1274,9 +1274,6 @@ static long mbochs_ioctl(struct vfio_device *vdev, unsigned int cmd,
static int mbochs_open(struct vfio_device *vdev) static int mbochs_open(struct vfio_device *vdev)
{ {
if (!try_module_get(THIS_MODULE))
return -ENODEV;
return 0; return 0;
} }
...@@ -1300,7 +1297,6 @@ static void mbochs_close(struct vfio_device *vdev) ...@@ -1300,7 +1297,6 @@ static void mbochs_close(struct vfio_device *vdev)
mbochs_put_pages(mdev_state); mbochs_put_pages(mdev_state);
mutex_unlock(&mdev_state->ops_lock); mutex_unlock(&mdev_state->ops_lock);
module_put(THIS_MODULE);
} }
static ssize_t static ssize_t
......
...@@ -611,15 +611,11 @@ static long mdpy_ioctl(struct vfio_device *vdev, unsigned int cmd, ...@@ -611,15 +611,11 @@ static long mdpy_ioctl(struct vfio_device *vdev, unsigned int cmd,
static int mdpy_open(struct vfio_device *vdev) static int mdpy_open(struct vfio_device *vdev)
{ {
if (!try_module_get(THIS_MODULE))
return -ENODEV;
return 0; return 0;
} }
static void mdpy_close(struct vfio_device *vdev) static void mdpy_close(struct vfio_device *vdev)
{ {
module_put(THIS_MODULE);
} }
static ssize_t static ssize_t
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment