Commit e31fbe10 authored by Colin Ian King's avatar Colin Ian King Committed by Kalle Valo

b43: fix unitialized reads of ret by initializing the array to zero

The u8 char array ret is not being initialized and elements outside
the range start to end contain just garbage values from the stack.
This results in a later scan of the array to read potentially
uninitialized values.  Fix this by initializing the array to zero.
This seems to have been an issue since the very first commit.

Detected by CoverityScan CID#139652 ("Uninitialized scalar variable")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarMichael Buesch <m@bues.ch>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 6508497c
...@@ -2297,7 +2297,7 @@ static u8 b43_gphy_aci_detect(struct b43_wldev *dev, u8 channel) ...@@ -2297,7 +2297,7 @@ static u8 b43_gphy_aci_detect(struct b43_wldev *dev, u8 channel)
static u8 b43_gphy_aci_scan(struct b43_wldev *dev) static u8 b43_gphy_aci_scan(struct b43_wldev *dev)
{ {
struct b43_phy *phy = &dev->phy; struct b43_phy *phy = &dev->phy;
u8 ret[13]; u8 ret[13] = { 0 };
unsigned int channel = phy->channel; unsigned int channel = phy->channel;
unsigned int i, j, start, end; unsigned int i, j, start, end;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment