Commit e620799c authored by I Hsin Cheng's avatar I Hsin Cheng Committed by Andrew Morton

list: test: fix tests for list_cut_position()

Fix test for list_cut_position*() for the missing check of integer "i"
after the second loop.  The variable should be checked for second time to
make sure both lists after the cut operation are formed as expected.

Link: https://lkml.kernel.org/r/20240910043531.71343-1-richard120310@gmail.comSigned-off-by: default avatarI Hsin Cheng <richard120310@gmail.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 13309764
...@@ -404,10 +404,13 @@ static void list_test_list_cut_position(struct kunit *test) ...@@ -404,10 +404,13 @@ static void list_test_list_cut_position(struct kunit *test)
KUNIT_EXPECT_EQ(test, i, 2); KUNIT_EXPECT_EQ(test, i, 2);
i = 0;
list_for_each(cur, &list1) { list_for_each(cur, &list1) {
KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]); KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]);
i++; i++;
} }
KUNIT_EXPECT_EQ(test, i, 1);
} }
static void list_test_list_cut_before(struct kunit *test) static void list_test_list_cut_before(struct kunit *test)
...@@ -432,10 +435,13 @@ static void list_test_list_cut_before(struct kunit *test) ...@@ -432,10 +435,13 @@ static void list_test_list_cut_before(struct kunit *test)
KUNIT_EXPECT_EQ(test, i, 1); KUNIT_EXPECT_EQ(test, i, 1);
i = 0;
list_for_each(cur, &list1) { list_for_each(cur, &list1) {
KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]); KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]);
i++; i++;
} }
KUNIT_EXPECT_EQ(test, i, 2);
} }
static void list_test_list_splice(struct kunit *test) static void list_test_list_splice(struct kunit *test)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment