Commit e8fb41ac authored by Lee Jones's avatar Lee Jones Committed by Zack Rusin

drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'shader_slot' not described in 'vmw_binding_add'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'slot' not described in 'vmw_binding_add'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:376: warning: Function parameter or member 'from' not described in 'vmw_binding_transfer'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Function parameter or member 'to' not described in 'vmw_binding_state_commit'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Excess function parameter 'ctx' description in 'vmw_binding_state_commit'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Excess function parameter 'scrubbed' description in 'vmw_binding_state_commit'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:520: warning: Function parameter or member 'cbs' not described in 'vmw_binding_rebind_all'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:520: warning: Excess function parameter 'ctx' description in 'vmw_binding_rebind_all'
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:795: warning: Function parameter or member 'shader_slot' not described in 'vmw_emit_set_sr'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-5-lee.jones@linaro.org
parent a5434770
...@@ -330,6 +330,8 @@ static void vmw_binding_drop(struct vmw_ctx_bindinfo *bi) ...@@ -330,6 +330,8 @@ static void vmw_binding_drop(struct vmw_ctx_bindinfo *bi)
* *
* @cbs: Pointer to the context binding state tracker. * @cbs: Pointer to the context binding state tracker.
* @bi: Information about the binding to track. * @bi: Information about the binding to track.
* @shader_slot: The shader slot of the binding.
* @slot: The slot of the binding.
* *
* Starts tracking the binding in the context binding * Starts tracking the binding in the context binding
* state structure @cbs. * state structure @cbs.
...@@ -367,6 +369,7 @@ void vmw_binding_add_uav_index(struct vmw_ctx_binding_state *cbs, uint32 slot, ...@@ -367,6 +369,7 @@ void vmw_binding_add_uav_index(struct vmw_ctx_binding_state *cbs, uint32 slot,
* vmw_binding_transfer: Transfer a context binding tracking entry. * vmw_binding_transfer: Transfer a context binding tracking entry.
* *
* @cbs: Pointer to the persistent context binding state tracker. * @cbs: Pointer to the persistent context binding state tracker.
* @from: Staged binding info built during execbuf
* @bi: Information about the binding to track. * @bi: Information about the binding to track.
* *
*/ */
...@@ -484,9 +487,8 @@ void vmw_binding_res_list_scrub(struct list_head *head) ...@@ -484,9 +487,8 @@ void vmw_binding_res_list_scrub(struct list_head *head)
/** /**
* vmw_binding_state_commit - Commit staged binding info * vmw_binding_state_commit - Commit staged binding info
* *
* @ctx: Pointer to context to commit the staged binding info to. * @to: Staged binding info area to copy into to.
* @from: Staged binding info built during execbuf. * @from: Staged binding info built during execbuf.
* @scrubbed: Transfer only scrubbed bindings.
* *
* Transfers binding info from a temporary structure * Transfers binding info from a temporary structure
* (typically used by execbuf) to the persistent * (typically used by execbuf) to the persistent
...@@ -511,7 +513,7 @@ void vmw_binding_state_commit(struct vmw_ctx_binding_state *to, ...@@ -511,7 +513,7 @@ void vmw_binding_state_commit(struct vmw_ctx_binding_state *to,
/** /**
* vmw_binding_rebind_all - Rebind all scrubbed bindings of a context * vmw_binding_rebind_all - Rebind all scrubbed bindings of a context
* *
* @ctx: The context resource * @cbs: Pointer to the context binding state tracker.
* *
* Walks through the context binding list and rebinds all scrubbed * Walks through the context binding list and rebinds all scrubbed
* resources. * resources.
...@@ -789,6 +791,7 @@ static void vmw_collect_dirty_view_ids(struct vmw_ctx_binding_state *cbs, ...@@ -789,6 +791,7 @@ static void vmw_collect_dirty_view_ids(struct vmw_ctx_binding_state *cbs,
* vmw_binding_emit_set_sr - Issue delayed DX shader resource binding commands * vmw_binding_emit_set_sr - Issue delayed DX shader resource binding commands
* *
* @cbs: Pointer to the context's struct vmw_ctx_binding_state * @cbs: Pointer to the context's struct vmw_ctx_binding_state
* @shader_slot: The shader slot of the binding.
*/ */
static int vmw_emit_set_sr(struct vmw_ctx_binding_state *cbs, static int vmw_emit_set_sr(struct vmw_ctx_binding_state *cbs,
int shader_slot) int shader_slot)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment